Devtools: show warning popup on auto type conversion #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobkaz
force-pushed
the
devtools/remove-command-type-conversion
branch
2 times, most recently
from
ffbce1d to
402d1eb
Compare
kobkaz
force-pushed
the
devtools/remove-command-type-conversion
branch
from
402d1eb to
a65dbc8
Compare
|
流石に window.alert はユーザーの操作をブロックしすぎなので、monaco decolation で warning 出すようにしました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
暗黙の型変換は望ましくないので、将来的になくすことを前提に警告を表示する
変更の意図や背景
発端となる Issue