Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit with error code if gh-federation failed #51

Merged
merged 1 commit into from
Feb 7, 2024
+3 −1
Merged

Exit with error code if gh-federation failed #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,15 @@ runs:
const accessToken = data["token"];
core.setSecret(accessToken);
core.exportVariable("GH_FEDERATION_ACCESS_TOKEN", accessToken);
break;
return;
} catch (e) {
console.log(`retrying (remain: ${RETRY_MAX - i})...`);
continue;
}
}

core.setFailed('The request was not successful')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be exit with 0 in successful case if you want to fail like this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh..., I missed it. I will fix it immediately.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

break at L42 -> return


- name: Store access token
shell: bash
run: |
Expand Down