[ATfE] Cherry-pick libcxx change in wchar inclusion guarding into 20.x #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is required for the newlib-nano library overlay implementation to work correctly, as it provides the definition of `mbstate_t` despite not providing wide-character support.
pratlucas
changed the base branch from
arm-software
to
release/arm-software/20.x
pratlucas
changed the title
voltur01
previously approved these changes
Mar 3, 2025
statham-arm
reviewed
Mar 3, 2025
There was a problem hiding this comment.
Since this is a cherry-pick of an upstream commit on main, it's probably a good idea to mention the original commit id somewhere.
The original commit hash on main is 7620011. But that doesn't match the value in the header line of the new patch file, presumably because it was cherry-picked before running git format-patch. Perhaps if you redid it with cherry-pick -x it would include a footer citing the original id?
|
Good catch @statham-arm , I've updated the patch file using |
statham-arm
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is required for the newlib-nano library overlay
implementation to work correctly, as it provides the definition
mbstate_tdespite not providing wide-character support.