Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move scheduling key check into the QueuedJobsIterator #4004

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Move scheduling key check into the QueuedJobsIterator #4004

wants to merge 6 commits into from

Conversation

d80tb7
Copy link
Collaborator

@d80tb7 d80tb7 commented Oct 12, 2024 •
edited
Loading

The scheduling key check used to be in theQueuedGangIterator. I've moved it to to the QueuedJobsIterator because:

  • It simplifies QueuedGangIterator
  • It means we exit asap if we know a job is unscheduable.
  • The QueuedJobsIterator is only used for Queued (i.e. not evicted) jobs. This means we don't have to mess around with invalidating and skipping scheduling keys.

@d80tb7 d80tb7 changed the title Move Scheduling Key Check into Move scheduling key check into the QueuedJobsIterator Oct 12, 2024
@d80tb7
lint
cc6ad22 
Signed-off-by: Chris Martin <[email protected]>
@d80tb7
more removal
5366aec 
Signed-off-by: Chris Martin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@d80tb7