Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Non interactive modes ( [Bug]: sanitize_input #324 ) #326

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[fix] Non interactive modes ( [Bug]: sanitize_input #324 ) #326

wants to merge 9 commits into from
+47 −22

Conversation

Tearran
Copy link
Member

@Tearran Tearran commented Dec 18, 2024

Issues

Staging for refining Non interactive modes.
added option "--noint"
stage "--api" for json I/O (currently only out).
Remove calls for sanitize_input in main binary options,

@Tearran Tearran linked an issue Dec 18, 2024 that may be closed by this pull request
[Bug]: sanitize_input does not work as expected #324
Open
1 task
@github-actions github-actions bot added the size/small PR with less then 50 lines label Dec 18, 2024
@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines and removed size/small PR with less then 50 lines labels Dec 18, 2024
@dimitry-ishenko
Copy link
Collaborator

@Tearran I will take a closer look when I get a chance, but on the first peek I was thinking maybe we can add have_stdin and have_stdout helpers or something similar to replace all the [[ -t 0 ]] and [[ -t 1 ]]. I've had a couple of them in my PRs and see a bunch more in yours.

@Tearran
Copy link
Member Author

Tearran commented Dec 22, 2024

Thanks. I support the use of have_stdin and have_stdout. but consider set_stdin set_stdout or get_ :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitry-ishenko dimitry-ishenko Awaiting requested review from dimitry-ishenko

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/medium PR with more then 50 and less then 250 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: sanitize_input does not work as expected
2 participants
@Tearran @dimitry-ishenko