Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non interactive modes ( [Bug]: sanitize_input #324 ) #326

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

Tearran
Copy link
Member

@Tearran Tearran commented Dec 18, 2024

Issues

Staging for refining Non interactive modes.
added option "--noint"
stage "--api" for json I/O (currently only out).
Remove calls for sanitize_input in main binary options,

@Tearran Tearran linked an issue Dec 18, 2024 that may be closed by this pull request
1 task
@github-actions github-actions bot added the size/small PR with less then 50 lines label Dec 18, 2024
@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines and removed size/small PR with less then 50 lines labels Dec 18, 2024
@dimitry-ishenko
Copy link
Collaborator

@Tearran I will take a closer look when I get a chance, but on the first peek I was thinking maybe we can add have_stdin and have_stdout helpers or something similar to replace all the [[ -t 0 ]] and [[ -t 1 ]]. I've had a couple of them in my PRs and see a bunch more in yours.

@Tearran
Copy link
Member Author

Tearran commented Dec 22, 2024

Thanks. I support the use of have_stdin and have_stdout. but consider set_stdin set_stdout or get_ :)

@Tearran Tearran changed the title [fix] Non interactive modes ( [Bug]: sanitize_input #324 ) Non interactive modes ( [Bug]: sanitize_input #324 ) Dec 27, 2024
@Tearran
Copy link
Member Author

Tearran commented Dec 27, 2024

I reverted armbian-config and moved the changes to armbian-config-dev.

./tools/armbian-config-dev --help

This setup could allow us to stage and refine these changes.

Staging changes may benefit the project by letting us iteratively improve semantics, naming conventions, json/module keys and functionalities.

This approach should help ensure that aspects which might be incomplete or not fully optimized can be refined in stages.

@github-actions github-actions bot added size/large PR with 250 lines or more and removed size/medium PR with more then 50 and less then 250 lines labels Jan 4, 2025
@github-actions github-actions bot added the size/medium PR with more then 50 and less then 250 lines label Jan 4, 2025
@github-actions github-actions bot removed the size/large PR with 250 lines or more label Jan 4, 2025
@Tearran
Copy link
Member Author

Tearran commented Jan 4, 2025

added timer function to help identify sections that are slow and may need optimization or separation to improve performance. may help pinpoint where the script might be experiencing delays and take appropriate actions to optimize those areas

replaced loading echo messages with function to output

./tools/armbian-config-dev

Initializing script: 0 seconds
Setting base data: 0 seconds
The current Armbian 24.8.4 stable (bookworm) is supported.: 4 seconds
Loaded Runtime variables...: 0 seconds
Loaded Dialog...: 0 seconds
Loaded Docs...: 0 seconds
Loaded System helpers...: 0 seconds
Loaded Network helpers...: 0 seconds
Loaded Software helpers...: 0 seconds
Loaded Runtime conditions...: 5 seconds
Armbian Config: The Next Generation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/medium PR with more then 50 and less then 250 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: sanitize_input does not work as expected
2 participants