Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attributes for calibration #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anujdeshpande
Copy link
Collaborator

No description provided.

Copy link

@Bucknalla Bucknalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the calibration example to this too please?

@anujdeshpande
Copy link
Collaborator Author

Can you add the calibration example to this too please?

Hey @Bucknalla just noticed this - it's already there? There's an example with shell that sets attributes - not sure what you mean otherwise

@Bucknalla
Copy link

@anujdeshpande it would be best to have a simple usage example and then calibration example as they are two separate concepts but I would be ok with one example as long as you can comment the workflow. As this is going to be public, it should be clear for someone who doesn't have our intimate knowledge of how to use it.

@anujdeshpande
Copy link
Collaborator Author

Got it!
I'll fix the same example and add a shell command to fetch the value as well (will do that in the other sensor too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants