Merge pull request #2 from artefactory/cn/fix/dynamic_update_rules_go…

…ogle_billing_budget cn/fix/dynamic_update_rules_google_billing_budget
artefactory-skaff · Sep 25, 2023 · 01e9e8f · 01e9e8f
2 parents ac20b4e + 6c0659c
commit 01e9e8f
Showing 1 changed file with 14 additions and 8 deletions.
diff --git a/budget.tf b/budget.tf
@@ -32,10 +32,13 @@ resource "google_billing_budget" "relative_amount_budget" {
     }
   }
 
-  all_updates_rule {
-    monitoring_notification_channels = var.budgets.relative_amount.alerts.notification_channels
-    pubsub_topic                     = var.budgets.relative_amount.alerts.pubsub_topic
-    disable_default_iam_recipients   = var.budgets.relative_amount.alerts.disable_default_iam_recipients
+  dynamic "all_updates_rule" {
+    for_each = length(var.budgets.relative_amount.alerts.notification_channels) > 0 ? [1] : []
+    content {
+      monitoring_notification_channels = var.budgets.relative_amount.alerts.notification_channels
+      pubsub_topic                     = var.budgets.relative_amount.alerts.pubsub_topic
+      disable_default_iam_recipients   = var.budgets.relative_amount.alerts.disable_default_iam_recipients
+    }
   }
 
   depends_on = [google_project_service.billingbudgets]
@@ -65,10 +68,13 @@ resource "google_billing_budget" "absolute_amount_budget" {
     }
   }
 
-  all_updates_rule {
-    monitoring_notification_channels = var.budgets.absolute_amount.alerts.notification_channels
-    pubsub_topic                     = var.budgets.absolute_amount.alerts.pubsub_topic
-    disable_default_iam_recipients   = var.budgets.absolute_amount.alerts.disable_default_iam_recipients
+  dynamic "all_updates_rule" {
+    for_each = length(var.budgets.relative_amount.alerts.notification_channels) > 0 ? [1] : []
+    content {
+      monitoring_notification_channels = var.budgets.relative_amount.alerts.notification_channels
+      pubsub_topic                     = var.budgets.relative_amount.alerts.pubsub_topic
+      disable_default_iam_recipients   = var.budgets.relative_amount.alerts.disable_default_iam_recipients
+    }
   }
 
   depends_on = [google_project_service.billingbudgets]