Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding integration test #23

Merged
merged 55 commits into from
Mar 26, 2024
Merged

feat: adding integration test #23

merged 55 commits into from
Mar 26, 2024

Conversation

nmathieufact
Copy link
Contributor

@nmathieufact nmathieufact commented Mar 21, 2024 •
edited
Loading

Description of the goal of the PR

Introduce integration tests

Changes this PR introduces (fill it before implementation)

LAST UPDATE (22/03/24)

  • the read function from detection txt has been simplified with read_csv function
  • the assertion method has been changed to array_equal between the 2 value arrays of each dataframe
  • the test script include the storage of output as text when text is failed

Checklist before requesting a review

  • The CI pipeline passes
  • I have typed my code
  • I have created / updated the docstrings
  • I have updated the README, if relevant
  • I have updated the requirements, if relevant
  • I have tested my code

@nmathieufact nmathieufact marked this pull request as ready for review March 22, 2024 00:45
TomDarmon
TomDarmon reviewed Mar 22, 2024
View reviewed changes
tests/test_model_regression.py Outdated Show resolved Hide resolved
tests/test_model_regression.py Outdated Show resolved Hide resolved
tests/test_model_regression.py Outdated Show resolved Hide resolved
tests/test_model_regression.py Outdated Show resolved Hide resolved
tristanpepinartefact
tristanpepinartefact reviewed Mar 26, 2024
View reviewed changes
tests/test_model_regression.py Outdated
df_detection = np.loadtxt(
TEST_INPUT_FOLDER / f"objects_detected_{video_number}.txt", delimiter=" "
)
print(df_detection)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retirer ce print

@nmathieufact nmathieufact merged commit 95372b9 into dev Mar 26, 2024
1 check passed
@nmathieufact nmathieufact deleted the feat/nm/integration_test branch March 26, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristanpepinartefact tristanpepinartefact tristanpepinartefact approved these changes

@TomDarmon TomDarmon TomDarmon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmathieufact @tristanpepinartefact @TomDarmon