Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deb: install build dependencies at build time #82

Merged
merged 1 commit into from
Nov 17, 2017

Conversation

scollazo
Copy link
Contributor

Else they need to be declared twice, in the control and in the dockerfile

Closes #58

Copy link
Member

@sevein sevein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to update the Dockerfiles so the build deps are not installed from there anymore?

@scollazo
Copy link
Contributor Author

Removing the packages from the dockerfile brings issues with other archivematica packages, should we address that here, or in a different issue?

Copy link
Member

@sevein sevein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be my choice @scollazo but do it as you prefer. If you're not addressing that now please file a new issue to deal with the dedup problem later. Thank you!

Else they need to be declared twice, in the control and in the dockerfile

Closes #58
@scollazo
Copy link
Contributor Author

Merging this, and working on #89 the rabbit hole we found.

@scollazo scollazo merged commit 69cb4ab into master Nov 17, 2017
@sevein sevein deleted the dev/issue-58-install-deps branch November 17, 2017 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants