Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: pipelines are not always discoverable #236

Open
sevein opened this issue Sep 22, 2017 · 5 comments
Open

Problem: pipelines are not always discoverable #236

sevein opened this issue Sep 22, 2017 · 5 comments

Comments

@sevein
Copy link
Member

sevein commented Sep 22, 2017

SS stores the remote_name of a pipeline when it's created for consequent API access, e.g. re-ingest.

remote_name = models.CharField(
    max_length=256,
    default=None,
    null=True,
    blank=True,
    help_text="Host or IP address of the pipeline server for making API calls.")

This field is also editable from the web interface.

When a pipeline is created via the SS API, this field is populated after the REMOTE_ADDR header unless the client provides a value via the remote_name property.

The problem is that the dashboard doesn't allow users to provide a custom value so SS always fallbacks to the value found in the REMOTE_ADDR header which is problematic under some circumstances.

@jrwdunham
Copy link
Contributor

Assuming a URL is scheme:[//[user[:password]@]host[:port]][/path][?query][#fragment], are you proposing adding a new attribute to Pipeline so that Pipeline().remote_url must be a valid scheme:[//host[:port]]?

Or are you thinking of modifying the logic around Pipeline().remote_name so we can accept both scheme-less and schemed URLs?

@sevein
Copy link
Member Author

sevein commented Sep 24, 2017

Or are you thinking of modifying the logic around Pipeline().remote_name so we can accept both scheme-less and schemed URLs?

I didn't think much about it but I like the way ^ sounds. It would mean that we can solve the problem without a database migration - is that ok?

@jrwdunham
Copy link
Contributor

Sounds good to me.

@sevein
Copy link
Member Author

sevein commented May 28, 2018

I think that this issue needs to remain open until SS learns a new parameter that allows the user to indicate the URI of the pipeline in the create pipeline endpoint. This parameter should be provided by Archivematica when it performs the self-registration process.

@sevein sevein self-assigned this Jun 8, 2018
@sevein sevein added the Status: in progress Issue that is currently being worked on. Waffle label. label Jun 8, 2018
@sevein sevein added this to the 0.12.0 milestone Jun 8, 2018
@sevein sevein removed this from the 0.12.0 milestone Jun 8, 2018
@sevein sevein removed Jisc RDSS Status: in progress Issue that is currently being worked on. Waffle label. labels Jun 8, 2018
@sevein
Copy link
Member Author

sevein commented Jun 8, 2018

@sromkey, I think that we can close this issue.

SS v0.11 included #267 which made the following changes:

  • Parse Pipeline.remote_name as URLs (797d6a9).
  • Create pipeline endpoint to honour remote_name(134e33b)
  • Add SS_INSECURE_SKIP_VERIFY env so TLS cert verification can be disabled when the scheme found in the URI is https (ecacbec7d066f072966fc15342417b3ac381b929)

I think that these changes together already enabled the dashboard to provide a URI as the remote name. The remaining changes (provide a URI) need to happen in the AM repo.

@sevein sevein removed their assignment May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants