Take pipeline remote url from env var #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't going to work if we want to set up two pipelines - is that going to be a problem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses https://github.com/JiscRDSS/rdss-archivematica/issues/63 / artefactual#236 (at least as a first pass solution)
We take an environment variable for the Dashboard API URL (as contactable by storage service) and use that for the remote_name, in preference to reading it from the
REMOTE_NAMEon the request.REMOTE_NAMEis still used as a backup option if the environment variable is not present.Further iterations of this could involve the Storage Service endpoint accepting another parameter which allows Dashboard to send the hostname as part of that call, but this will get things working here for now.
See also https://github.com/JiscRDSS/rdss-archivematica/pull/103