OkHttp 3.1.2, Retrofit 2.0.0-beta4, Stetho 1.3.0 #88

artem-zinnatullin · 2016-02-07T18:34:47Z

Closes #87, closes #70.

Required quite a lot changes because both OkHttp and Retrofit now in new packages w/ version number + OkHttp is now immutable but at the same time we have 2 interceptors for debug only build, so, yeah.

@vanniktech PTAL :)

artem-zinnatullin · 2016-02-07T19:00:26Z

Hm, looks like Robolectric has some problems with OkHttp 3.1.0

com.artemzin.qualitymatters.ui.fragments.ItemsFragmentTest > onTryAgainButtonClick_shouldRequestDataFromPresenter STANDARD_ERROR
    java.lang.IllegalStateException: Unable to extract the trust manager on okhttp3.internal.Platform$Android@483cacc0, sslSocketFactory is class sun.security.ssl.SSLSocketFactoryImpl
        at okhttp3.OkHttpClient.<init>(OkHttpClient.java:187)
        at okhttp3.OkHttpClient.<init>(OkHttpClient.java:60)
        at okhttp3.OkHttpClient$Builder.build(OkHttpClient.java:719)
        at com.artemzin.qualitymatters.network.NetworkModule.provideOkHttpClient(NetworkModule.java:34)
        at com.artemzin.qualitymatters.network.NetworkModule_ProvideOkHttpClientFactory.get(NetworkModule_ProvideOkHttpClientFactory.java:27)
        at com.artemzin.qualitymatters.network.NetworkModule_ProvideOkHttpClientFactory.get(NetworkModule_ProvideOkHttpClientFactory.java:10)
        at dagger.internal.ScopedProvider.get(ScopedProvider.java:46)
        at com.artemzin.qualitymatters.developer_settings.DeveloperSettingsModule_ProvideDeveloperSettingsModelImplFactory.get(DeveloperSettingsModule_ProvideDeveloperSettingsModelImplFactory.java:40)
        at com.artemzin.qualitymatters.developer_settings.DeveloperSettingsModule_ProvideDeveloperSettingsModelImplFactory.get(DeveloperSettingsModule_ProvideDeveloperSettingsModelImplFactory.java:11)
        at dagger.internal.ScopedProvider.get(ScopedProvider.java:46)
        at com.artemzin.qualitymatters.developer_settings.DeveloperSettingsModule_ProvideDeveloperSettingsModelFactory.get(DeveloperSettingsModule_ProvideDeveloperSettingsModelFactory.java:21)
        at com.artemzin.qualitymatters.developer_settings.DeveloperSettingsModule_ProvideDeveloperSettingsModelFactory.get(DeveloperSettingsModule_ProvideDeveloperSettingsModelFactory.java:7)
        at dagger.internal.DoubleCheckLazy.get(DoubleCheckLazy.java:49)
        at com.artemzin.qualitymatters.QualityMattersApp.onCreate(QualityMattersApp.java:51)
        at org.robolectric.internal.ParallelUniverse.setUpApplicationState(ParallelUniverse.java:140)
        at org.robolectric.RobolectricTestRunner.setUpApplicationState(RobolectricTestRunner.java:433)
        at org.robolectric.RobolectricTestRunner$2.evaluate(RobolectricTestRunner.java:240)
        at org.robolectric.RobolectricTestRunner.runChild(RobolectricTestRunner.java:188)
        at org.robolectric.RobolectricTestRunner.runChild(RobolectricTestRunner.java:54)
        at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
        at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
        at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
        at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
        at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
        at org.robolectric.RobolectricTestRunner$1.evaluate(RobolectricTestRunner.java:152)
        at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
        at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
        at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
        at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
        at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
        at sun.reflect.GeneratedMethodAccessor44.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:497)
        at org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
        at org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
        at org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
        at org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
        at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
        at org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
        at sun.reflect.GeneratedMethodAccessor43.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:497)
        at org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
        at org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
        at org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
        at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
        at org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)

com.artemzin.qualitymatters.ui.fragments.ItemsFragmentTest > onTryAgainButtonClick_shouldRequestDataFromPresenter FAILED
    java.lang.RuntimeException: java.lang.IllegalStateException: Unable to extract the trust manager on okhttp3.internal.Platform$Android@483cacc0, sslSocketFactory is class sun.security.ssl.SSLSocketFactoryImpl

        Caused by:
        java.lang.IllegalStateException: Unable to extract the trust manager on okhttp3.internal.Platform$Android@483cacc0, sslSocketFactory is class sun.security.ssl.SSLSocketFactoryImpl

Will investigate later.

meoyawn · 2016-02-07T19:07:33Z

app/src/main/java/com/artemzin/qualitymatters/api/ApiModule.java

-
-        return builder.build().create(QualityMattersRestApi.class);
+                .addCallAdapterFactory(RxJavaCallAdapterFactory.create())
+                .validateEagerly(BuildConfig.DEBUG)  // Fail early: check Retrofit configuration at creation time in Debug build.


what about doing this in a unit test instead?

Good idea! The only downside of this is that it'll require providing Retrofit.Builder, but seems like worth it

Created #92 for this, will go into separate PR

vanniktech · 2016-02-07T19:56:27Z

@artem-zinnatullin looks good on my side. 👍 I have only the one suggestion regarding the @Named in dagger.

Since I haven't upgraded OkHttp in my projects to 3 yet, I haven't experienced this Robolectric issue.

artem-zinnatullin · 2016-02-07T22:26:25Z

Found the issue with OkHttp square/okhttp#2323, 3.0.1 doesn't have such problem.

// Another thing is that many classes in OkHttp are now final… uh

artem-zinnatullin · 2016-02-07T22:30:26Z

Duck, in 3.1.0 OkHttpClient now back non-final, dependency trap 😿

artem-zinnatullin · 2016-02-07T22:32:22Z

I don't want to use PowerMock or other solutions, so, I'd wait for 3.1.1, should be released soon.

artem-zinnatullin · 2016-02-08T04:11:07Z

Unfortunately, OkHttp 3.1.1 didn't fix that, will continue monitoring the situation.

vanniktech · 2016-02-08T09:05:37Z

Hmm that's a bummer. Let's hope 3.1.2 will fix this.

vanniktech · 2016-02-11T12:28:10Z

@artem-zinnatullin I think 3.1.2 fixed the robolectric issue.

artem-zinnatullin · 2016-02-11T14:41:27Z

Yup, will try soon

On Thu, 11 Feb 2016, 07:28 Niklas Baudy [email protected] wrote:

@artem-zinnatullin https://github.com/artem-zinnatullin I think 3.1.2
fixed the robolectric issue.

—
Reply to this email directly or view it on GitHub
#88 (comment)
.

@artem_zin

artem-zinnatullin · 2016-02-15T04:35:05Z

@vanniktech fixed comments!

vanniktech · 2016-02-15T08:19:44Z

Nice 👍

OkHttp 3.1.2, Retrofit 2.0.0-beta4, Stetho 1.3.0

artem-zinnatullin added the enhancement label Feb 7, 2016

artem-zinnatullin self-assigned this Feb 7, 2016

artem-zinnatullin added this to the v1.0 milestone Feb 7, 2016

meoyawn reviewed Feb 7, 2016
View reviewed changes

artem-zinnatullin force-pushed the okhttp-3-retrofit-new-beta branch from 1c973e6 to 0ae886f Compare February 11, 2016 21:15

artem-zinnatullin changed the title ~~OkHttp 3.1.0, Retrofit 2.0.0-beta4, Stetho 1.3.0~~ OkHttp 3.1.2, Retrofit 2.0.0-beta4, Stetho 1.3.0 Feb 11, 2016

artem-zinnatullin force-pushed the okhttp-3-retrofit-new-beta branch from 0ae886f to 40e9687 Compare February 12, 2016 07:32

artem-zinnatullin mentioned this pull request Feb 15, 2016

Check Retrofit configuration as test instead of doing this in debug builds #92

Open

artem-zinnatullin force-pushed the okhttp-3-retrofit-new-beta branch 3 times, most recently from fb39e7f to aa8d08b Compare February 15, 2016 04:21

OkHttp 3.1.2, Retrofit 2.0.0-beta4, Stetho 1.3.0

aa8d08b

artem-zinnatullin added a commit that referenced this pull request Feb 15, 2016

Merge pull request #88 from artem-zinnatullin/okhttp-3-retrofit-new-beta

c34a76e

OkHttp 3.1.2, Retrofit 2.0.0-beta4, Stetho 1.3.0

artem-zinnatullin merged commit c34a76e into master Feb 15, 2016

artem-zinnatullin deleted the okhttp-3-retrofit-new-beta branch February 15, 2016 15:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OkHttp 3.1.2, Retrofit 2.0.0-beta4, Stetho 1.3.0 #88

OkHttp 3.1.2, Retrofit 2.0.0-beta4, Stetho 1.3.0 #88

artem-zinnatullin commented Feb 7, 2016

artem-zinnatullin commented Feb 7, 2016

meoyawn Feb 7, 2016

artem-zinnatullin Feb 7, 2016

artem-zinnatullin Feb 15, 2016

vanniktech commented Feb 7, 2016

artem-zinnatullin commented Feb 7, 2016

artem-zinnatullin commented Feb 7, 2016

artem-zinnatullin commented Feb 7, 2016

artem-zinnatullin commented Feb 8, 2016

vanniktech commented Feb 8, 2016

vanniktech commented Feb 11, 2016

artem-zinnatullin commented Feb 11, 2016

artem-zinnatullin commented Feb 15, 2016

vanniktech commented Feb 15, 2016

OkHttp 3.1.2, Retrofit 2.0.0-beta4, Stetho 1.3.0 #88

OkHttp 3.1.2, Retrofit 2.0.0-beta4, Stetho 1.3.0 #88

Conversation

artem-zinnatullin commented Feb 7, 2016

artem-zinnatullin commented Feb 7, 2016

meoyawn Feb 7, 2016

Choose a reason for hiding this comment

artem-zinnatullin Feb 7, 2016

Choose a reason for hiding this comment

artem-zinnatullin Feb 15, 2016

Choose a reason for hiding this comment

vanniktech commented Feb 7, 2016

artem-zinnatullin commented Feb 7, 2016

artem-zinnatullin commented Feb 7, 2016

artem-zinnatullin commented Feb 7, 2016

artem-zinnatullin commented Feb 8, 2016

vanniktech commented Feb 8, 2016

vanniktech commented Feb 11, 2016

artem-zinnatullin commented Feb 11, 2016

artem-zinnatullin commented Feb 15, 2016

vanniktech commented Feb 15, 2016