1.4.0 pre-release version #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
variant caller
BioWilko
added a commit
that referenced
this pull request
Nov 13, 2024
* 1.4.0 pre-release version (#135) * Deprecate old tools and black format * Support fragmented data * use new trim primer arg in minion * reverse the (revolting) primer position logic * Fix find primer logic * Improve the cursed report writer logic * explicitly named function args, what a novel idea * add temp debugging prints to find_primer * Add logic to handle segments outside of primer scheme * fix typo * General bugfixes, test fix for overlapping variant issue * add min mapq argument * properly provide min_mapq to handle_segment * Fix unmatched read group issue * Fix 8 bit int error * First attempt to integrate clair3 as optional variant caller * Slightly change env yaml format * Specify env name in mamba gh action * Checkout repo before installing env * python 3.6.15 * Run on ubuntu 20.04 * unpin python * Unpin python entirely * Separate out tests * correct unit test path * remove retvar hints for compatibility * Fix silly relative imports * Switch to cyvcf and fix unit tests * Fix pipeline parse unit test * Fix fstring * Large changes to make clair3 work, various unit test updates * Fix fuzzy primer site match logic * Fix minion_validator path * Fix vcf merge bug with empty VCF files * Increase fuzzy match default threshold to 20 * Fix CHROM bug in vcf merge properly * Report failed workflow when variants are missed * Fix vcf merge again * Separate out tests * No counter anymore * Add C241T to SP1 variants * Add limit on ref pileup * Single copy of CVR1 12733 var * re-enable other consensus tests * First attempt to make minion validator less fragile * Unify testvariants, improve test logic * medaka has to be different smh * Index ref fasta when using the clair3 workflow * Add mean amplicon depth TSV output * Update CLI and scheme fetcher * Update align trim unit test * Use proper version of V3 bedfile * Fix pipeline unit test * Fix align trim amp depth bug * Call variants on non primertrimmed bam * Don't test MT vs clair * properly disable test * Add docker build push action on release * Grab wget in dockerfile * Update docs and readme * docker push on release only * Remove debugging print statement * Make fuzzy primer match logic clearer * Install procps for nxf compatibility * 1.4.0 dev m1 (#136) * mods to Dockerfile * wip * update * 1.4.1 version bump * Properly name fasta header * Fix correctly paired logic * Version bump * Fix double gzipping of vcf issue * Version bump * Ignore deletions in depth masking * Remove medaka and longshot, pre 1.4.5 push * Fix args.clair3 reference * Fix artic.utils import * Remove defaults from conda env yaml * Update docs / changelog * Add min-depth and min-variant-quality arguments * Fix colored file arg * 1.4.6 version bump * Fix small check_filter bug * Version bump * rename minion model-path to model-dir * version bump * Fix model_dir arg in minion * Add stale issues gh action * 1.5 version bump * properly put low quality variants in mask * 1.5.1 version bump * Update vcf filtering and clair3 command --------- Co-authored-by: Rachel Colquhoun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARTIC Fieldbioinformatics v1.4.0
Well hasn't this been a long time coming?
Major Changes:
--clair3argument toartic minion. By default only r9.4.1 models are available but r10.4.1 models are available from the ONT Rerio repository.--bedand--ref.