feat: cloudflare r2 for blog assets #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lace content with the signed URL
…dentifying corresponding notion-r2 images further down the road
… exist, and replace content with the signed url
|
Deploy job was skipped, because: Since build passes, merging. Should deploy from main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: initial attempt—upload notion's assets to cloudflare r2 and replace content with the signed URL
fix: use blockId instead of a date/time combo; this would allow for identifying corresponding notion-r2 images further down the road
fix: path within bucket in listObjects util
feat: upload image to r2 only if the slug-blockId combination doesn't exist, and replace content with the signed url
feat: handle image uploads for all blog posts
feat: actually handle image uploads and replacements for all blog posts