-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add macOS arm64 support and use latest runners for cibuildwheel #7548
Conversation
3c5fd70
to
546e7b2
Compare
https://github.com/arvidn/libtorrent/actions/runs/6868842497/job/18680371514?pr=7548#step:5:85
|
@arvidn Can you kill all the runs? The problem is there's no
|
52d7cf2
to
0b0d265
Compare
{"os": "macos-12", "CIBW_BUILD": "cp37-*", "CIBW_ARCHS": "x86_64"}, | ||
{"os": "windows-2022", "CIBW_BUILD": "cp37-*", "CIBW_ARCHS": "AMD64"} | ||
{"os": "macos-latest", "CIBW_BUILD": "cp37-*", "CIBW_ARCHS": "x86_64"}, | ||
{"os": "macos-latest", "CIBW_BUILD": "cp39-*", "CIBW_ARCHS": "arm64"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI fails on wheel repair, specifically
delocate.delocating.DelocationError: Some missing architectures in wheel
Required arch arm64 missing from /usr/local/Cellar/openssl@3/3.1.4/lib/libssl.3.dylib
Required arch arm64 missing from libtorrent/__init__.cpython-39-darwin.so
so it looks like libtorrent wasn't built with arm64 support and openssl doesn't have it either. Here's how pygit2 went about it https://github.com/libgit2/pygit2/blob/master/.github/workflows/wheels.yml#L41C16-L41C16 , it builds openssl and itself with arm64 support before creating wheels CIBW_BEFORE_ALL
and then uses a custom CIBW_REPAIR_WHEEL_COMMAND_MACOS
to repair them. Looks we'll have to do the same here. Also might as well build universal wheels here instead of just arm64
, so that we can drop pure x86_64
later on (though maybe this is arguable).
I closed this as it looks like this needs to be done in 2 PR's....Cirrus CI & CI build wheel. @arvidn Cirrus would probably need to migrate to: Newer FreeBSD OS 14-0 Python 3.7 is now EOL & 3.8 only has 9 months left so unsure if you want to drop those?? |
Bumped:
macos-12
->macos-latest
windows-12
->windows-latest
v3
->v4
v2
->v3
v2.12.3
->v2.16.2
(python 3.12 support)