Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add macOS arm64 support for cibuildwheel #7606

Closed
wants to merge 1 commit into from
Closed

Add macOS arm64 support for cibuildwheel #7606

wants to merge 1 commit into from

Conversation

xavier2k6
Copy link
Contributor

No description provided.

@xavier2k6 xavier2k6 force-pushed the wheel branch 4 times, most recently from 8ec75c5 to 56ce71c Compare February 10, 2024 20:10
@xavier2k6
Copy link
Contributor Author

@arvidn This is still a WIP......

@xavier2k6 xavier2k6 force-pushed the wheel branch 4 times, most recently from 99a8ae2 to 60b6939 Compare February 24, 2024 11:18
@xavier2k6
Copy link
Contributor Author

@qstokkink, @arvidn made some changes with updated boost/python versions, please have a look, libsimulator used is outdated hence simulation failures.

@xavier2k6 xavier2k6 changed the title Add macOS arm64 support and use latest runners for cibuildwheel Add macOS arm64 support for cibuildwheel Jun 12, 2024
@qstokkink
Copy link

I'm no Mac user and⸺as "just some random person"⸺I definitely have no say in the minimum supported Python version. However, your output suggests that MACOSX_DEPLOYMENT_TARGET should be set to 13 for macos-13 and to 14 for macos-14.

@xavier2k6
Copy link
Contributor Author

I'm no Mac user and⸺as "just some random person"⸺I definitely have no say in the minimum supported Python version. However, your output suggests that MACOSX_DEPLOYMENT_TARGET should be set to 13 for macos-13 and to 14 for macos-14.

I only changed mins for any possible deprecations/highlight issues.

@xavier2k6
Copy link
Contributor Author

@arvidn Windows cibuildwheel passed in my latest changes, please review the windows.yml failures where I used Boost 1.82.0 whenever boost was being used.

@qstokkink qstokkink mentioned this pull request Jun 13, 2024
Merged
@arvidn
Copy link
Owner

arvidn commented Jun 13, 2024

now might be a good time to retry this, on top of latest RC_2_0

@xavier2k6
Copy link
Contributor Author

xavier2k6 commented Jun 13, 2024 •
edited
Loading

now might be a good time to retry this, on top of latest RC_2_0

Having issues rebasing due to partial commit with libsimulator

Also, see #7684 (comment)

@xavier2k6 xavier2k6 closed this Aug 9, 2024
@xavier2k6 xavier2k6 deleted the wheel branch August 9, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xavier2k6 @qstokkink @arvidn