Adding New Rootogram Plot

pyproject.toml

@@ -27,7 +27,7 @@ classifiers = [
 dynamic = ["version", "description"]
 dependencies = [
   "arviz-base==0.2",
-  "arviz-stats[xarray]==0.2",
+  "arviz-stats[xarray] @ git+https://github.com/arviz-devs/arviz-stats@get_bins",
 ]
 
 [tool.flit.module]

src/arviz_plots/backend/matplotlib/__init__.py

@@ -216,17 +216,15 @@ def hist(
     artist_kws.setdefault("zorder", 2)
     widths = np.asarray(r_e) - np.asarray(l_e)
     if np.any(bottom != 0):
-        height = y - bottom
-    else:
-        height = y
+        y = y - bottom  # making y the top coordinate and not height
     if color is not unset:
         if facecolor is unset:
             facecolor = color
         if edgecolor is unset:
             edgecolor = color
     kwargs = {"bottom": bottom, "color": facecolor, "edgecolor": edgecolor, "alpha": alpha}
     return target.bar(
-        l_e, height, width=widths, align="edge", **_filter_kwargs(kwargs, None, artist_kws)
+        l_e, y, width=widths, align="edge", **_filter_kwargs(kwargs, None, artist_kws)
     )
 
 

src/arviz_plots/backend/none/__init__.py

@@ -189,8 +189,19 @@ def _filter_kwargs(kwargs, artist_kws):
     return {**artist_kws, **kwargs}
 
 
+# "geoms"
 def hist(
-    y, l_e, r_e, target, *, bottom=None, color=unset, facecolor=unset, edgecolor=unset, **artist_kws
+    y,
+    l_e,
+    r_e,
+    target,
+    *,
+    bottom=None,
+    color=unset,
+    alpha=unset,
+    facecolor=unset,
+    edgecolor=unset,
+    **artist_kws,
 ):
     """Interface to matplotlib for a histogram bar plot."""
     if not ALLOW_KWARGS and artist_kws:
@@ -200,7 +211,7 @@ def hist(
             facecolor = color
         if edgecolor is unset:
             edgecolor = color
-    kwargs = {"bottom": bottom, "facecolor": facecolor, "edgecolor": edgecolor}
+    kwargs = {"bottom": bottom, "alpha": alpha, "facecolor": facecolor, "edgecolor": edgecolor}
     artist_element = {
         "function": "hist",
         "l_e": np.atleast_1d(l_e),
@@ -212,7 +223,6 @@ def hist(
     return artist_element
 
 
-# "geoms"
 def line(x, y, target, *, color=unset, alpha=unset, width=unset, linestyle=unset, **artist_kws):
     """Interface to a line plot."""
     kwargs = {"color": color, "alpha": alpha, "width": width, "linestyle": linestyle}

src/arviz_plots/plots/__init__.py

@@ -4,6 +4,7 @@
 from .distplot import plot_dist
 from .forestplot import plot_forest
 from .ridgeplot import plot_ridge
+from .rootogramplot import plot_rootogram
 from .tracedistplot import plot_trace_dist
 from .traceplot import plot_trace
 
@@ -14,4 +15,5 @@
     "plot_trace",
     "plot_trace_dist",
     "plot_ridge",
+    "plot_rootogram",
 ]

src/arviz_plots/plots/distplot.py

@@ -1,4 +1,5 @@
 """dist plot code."""
+
 import warnings
 from copy import copy
 from importlib import import_module
@@ -358,7 +359,9 @@ def plot_dist(
             point_density_diff = [
                 dim for dim in density.sel(plot_axis="histogram").dims if dim not in point.dims
             ]
-            point_density_diff = ["hist_dim"] + point_density_diff
+            point_density_diff = [
+                f"hist_dim_{var_name}" for var_name in density.data_vars
+            ] + point_density_diff
             point_y = 0.04 * density.sel(plot_axis="histogram", drop=True).max(
                 dim=point_density_diff
             )