Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Problem with orientation change and supported Swift 5 #40

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fixed Problem with orientation change and supported Swift 5 #40

wants to merge 6 commits into from

Conversation

cafedeichi
Copy link

@cafedeichi cafedeichi commented Aug 17, 2020 •
edited
Loading

fix: #33

  • Fixed the orientation change issue by moving the procedures from scrollViewDidScroll to scrollViewDidEndDecelerating and recalculate the contentOffset in redrawComponents.

  • Supported Swift 5.

  • Updated Deployment Target to 9.0

  • Modified ScrollPager.podspec and .travis.yml

@cafedeichi cafedeichi changed the title Fixed #33 Fixed Problem with orientation change. Aug 17, 2020
@cafedeichi cafedeichi changed the title Fixed Problem with orientation change. Fixed Problem with orientation change Aug 17, 2020
@cafedeichi cafedeichi changed the title Fixed Problem with orientation change Fixed Problem with orientation change and supported Swift 5 Aug 17, 2020
@cafedeichi cafedeichi mentioned this pull request Aug 20, 2020
Open
@smamczak
Copy link

Works great!

You forgot to add the new method argument for interface builder

Zrzut ekranu 2020-10-15 o 20 12 26

@cafedeichi
Copy link
Author

@smamczak
Thx. I fixed it 👍

@aryaxt
Hoping you could review my PR!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem with orientation change
2 participants
@cafedeichi @smamczak