Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development #51

Closed
wants to merge 2 commits into from
Closed

Development #51

wants to merge 2 commits into from

Conversation

asadarafat
Copy link
Owner

No description provided.

@asadarafat asadarafat closed this Oct 31, 2024
Repository owner deleted a comment from gitguardian bot Oct 31, 2024
@asadarafat asadarafat reopened this Oct 31, 2024
Copy link

gitguardian bot commented Oct 31, 2024

⚠️ GitGuardian has uncovered 23 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14358214 Triggered RSA Private Key aaa2bf1 rawTopoFile/clab-demo/.tls/Leaf-01/Leaf-01.key View secret
14358214 Triggered RSA Private Key aaa2bf1 rawTopoFile/clab-demo/Leaf-01/config/tls/clab-profile.key.pem View secret
14358215 Triggered Generic Password aaa2bf1 rawTopoFile/clab-demo/Leaf-01/config/aaamgr_local_user.json View secret
14358215 Triggered Generic Password aaa2bf1 rawTopoFile/clab-demo/Leaf-02/config/aaamgr_local_user.json View secret
14358215 Triggered Generic Password aaa2bf1 rawTopoFile/clab-demo/Leaf-03/config/aaamgr_local_user.json View secret
14358216 Triggered Generic Password aaa2bf1 rawTopoFile/clab-demo/Leaf-02/config/checkpoint/checkpoint-0.json View secret
14358216 Triggered Generic Password aaa2bf1 rawTopoFile/clab-demo/Leaf-01/config/checkpoint/checkpoint-0.json View secret
14358216 Triggered Generic Password aaa2bf1 rawTopoFile/clab-demo/Leaf-02/config/config.json View secret
14358216 Triggered Generic Password aaa2bf1 rawTopoFile/clab-demo/Leaf-03/config/checkpoint/checkpoint-0.json View secret
14358216 Triggered Generic Password aaa2bf1 rawTopoFile/clab-demo/Leaf-03/config/config.json View secret
14358216 Triggered Generic Password aaa2bf1 rawTopoFile/clab-demo/Leaf-01/config/config.json View secret
14358217 Triggered RSA Private Key aaa2bf1 rawTopoFile/clab-demo/.tls/Leaf-04/Leaf-04.key View secret
14358218 Triggered RSA Private Key aaa2bf1 rawTopoFile/clab-demo/.tls/Leaf-02/Leaf-02.key View secret
14358218 Triggered RSA Private Key aaa2bf1 rawTopoFile/clab-demo/Leaf-02/config/tls/clab-profile.key.pem View secret
14358219 Triggered RSA Private Key aaa2bf1 rawTopoFile/clab-demo/.tls/Spine-02/Spine-02.key View secret
14358220 Triggered RSA Private Key aaa2bf1 rawTopoFile/clab-demo/.tls/Spine-01/Spine-01.key View secret
14358221 Triggered RSA Private Key aaa2bf1 rawTopoFile/clab-demo/.tls/Leaf-03/Leaf-03.key View secret
14358222 Triggered RSA Private Key aaa2bf1 rawTopoFile/clab-demo/.tls/ca/ca.key View secret
14306804 Triggered Username Password 78b3a3f dist/config/topoviewer-config.yaml View secret
2883182 Triggered Generic Password 78b3a3f config/topoviewer-config.yaml View secret
2883182 Triggered Generic Password 78b3a3f dist/config/topoviewer-config.yaml View secret
14306804 Triggered Username Password 78b3a3f config/topoviewer-config.yaml View secret
5019126 Triggered Generic Password 78b3a3f dist/config/antareja-config.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

aarafat-me and others added 2 commits October 31, 2024 11:24
dev

init

init

init

init

init

init

init

init

init

init

init

init

init

init

init

init

init

init

init

init

init

init

init

init

init

init

init

init

init

init

init

init

init

init

init

ui

update

ui

dev

dev

dev

dev

Create docker-ci.yml

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

Update Dockerfile

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

:

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

Update Dockerfile

Update Dockerfile

dev
Please enter the commit message for your changes. Lines starting

dev
Please enter the commit message for your changes. Lines starting

dev

dev

dev

dev

dev

dev

dev

dev

dev-fix

dev-fix

dev

dev

dev

dev

dev

dev

dev

dev

dev

test

dev

dev

dev

asd

dev

dev

dev

d

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

Update cloudshell-index.tmpl

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

asad

dev

dev

dev

dev

dev

dev

dev

dev

Update Dockerfile

dev

dev

dev

dev

dev

23.8.1

23.8.1

23.8.1

23.8.1

23.8.2

23.8.3

23.8.3

23.8.3

23.8.3

23.8.3

23.8.7

23.8.8

23.8.8

23.8.8

23.8.9

23.8.9

v23.8.13

v23.8.13

"v23.8.13"

"v23.8.13a"

"v23.8.13b"

"v23.8.14"

v23.8.14

"v23.8.15"

"23.9.8"

v23.9.8

dev

dev

dev

dev

dev

"23.9.15"

"23.9.15"

"23.9.16"

"23.9.17"

dev

"23.9.18"

dev

"23.9.16a"

dev

"23.9.16b"

dev

dev

"23.9.16c"

"23.9.16d"

"23.9.16e"

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

"nightly-23.10.01"

"nightly-23.10.01"

dev

dev

"nightly-23.10.02"

dev

dev

dev

"nightly-23.10.02-a"

dev

dev

"nightly-23.10.02"

dev

dev

dev

dev

dev

dev

dev

dev

"nightly-23.10.02"

"nightly-23.10.03"

dev

"nightly-23.10.03"

dev

dev

"nightly-23.10.04"

"nightly-23.10.04"

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

commit with tag nightly-23.10.12

commit

commit with tag nightly-23.10.12

commit with tag nightly-23.10.12a

commit with tag nightly-23.10.12b

commit with tag nightly-23.10.12

commit with tag nightly-23.10.14

commit with tag nightly-23.10.15

commit with tag nightly-23.10.15

commit with tag nightly-23.10.15

commit with tag nightly-23.10.15a

commit with tag nightly-23.10.15b

commit with tag nightly-23.10.15c

commit with tag nightly-23.10.15d

commit with tag nightly-23.10.15e

commit with tag nightly-23.10.17

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

commit with tag nightly-23.10.22

dev

dev

dev

dev

de

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

dev

commit with tag nightly-23.10.22a

commit with tag nightly-23.10.22b

dev

dev

dev

dev

dev

commit with tag nightly-23.12.28

commit with tag nightly-23.12.28a

Update docker-ci-v2.yml

fix #32

Add sudo and containerlab fullpath when executing
clab netem command

fix #33

Fix #34
Change approach from executing command in clab servers
to generate ssh command which can be copied on user terminal

Update docker-ci-v3.yaml to support
tag extraction from git tag reference

Change github worflow docker-ci-v2.yaml to be
same as master/main branch

commit with tag nightly-23.12.28b

 Please enter the commit message for your changes. Lines starting

commit with tag nightly-24.01.09h

test

asad

commit with tag nightly-24.01.13

commit with tag nightly-24.01.13a

commit with tag nightly-24.01.13b

commit with tag nightly-24.01.13c

commit with tag nightly-24.01.13e

commit with tag nightly-24.01.13h

commit with tag nightly-24.01.13i

commit with tag

commit with tag nightly-24.01.13k

commit with tag nightly-24.01.13l

commit with tag nightly-24.01.13m

commit with tag nightly-24.01.18

commit with tag nightly-24.01.18a

commit with tag nightly-24.01.18b

commit with tag nightly-24.01.18b

commit with tag nightly-24.01.18c

commit with tag nightly-24.01.18d

commit with tag nightly-24-01-21

commit with tag nightly-24-01-21a

commit with tag nightly-24.01.21b

commit with tag nightly-24.01.21c

commit with tag nightly-24.01.21d

commit with tag nightly-24.01.21e

asad

commit with tag nightly-24.01.21d

commit with tag nightly-24.01.21e

commit with tag nightly-24.01.21f

commit with tag nightly-24.02.21g

commit with tag nightly-24.01.21h

commit with tag nightly-24.01.21i

commit with tag nightly-24.01.21h

commit with tag nightly-24.01.21j

commit with tag nightly-24.01.21k

commit with tag nightly-24.01.21l

commit with tag nightly-24.01.21m

commit with tag nightly-24.01.21n

Update docker-ci-v2.yml

test

commit with tag nightly-24.01.21o

Update docker-ci-v4.yml

Update docker-ci-v4.yml

Update docker-ci-v4.yml

Update docker-ci-v4.yml

Update docker-ci-v4.yml

Update docker-ci-v4.yml

commit with tag nightly-24.01.21j

Create main.yml

commit with tag nightly-24.01.21p

asd

asd

commit with tag nightly-24.01.22a

commit with tag nightly-24.01.22a

commit with tag nightly-23.01.24a

commit with tag nightly-23.01.24a

commit with tag nightly-23.01.24b

commit with tag nightly-24.01.22b

commit with tag nightly-24.01.24a

commit with tag nightly-24.01.24b

commit with tag nightly-24.01.24c

commit with tag nightly-24.01.24d

commit with tag nightly-24.01.26

commit with tag nightly-24.01.21p

Update docker-ci-v4.yml

Update docker-ci-v4.yml

dev

dev

commit with tag nightly-24.01.30

commit with tag nightly-24.01.30a

commit with tag nightly-24.01.30b

commit with tag nightly-24.02.03

commit with tag nightly-24.02.03a

commit with tag nightly24.02.03b

dev

commit with tag nightly24.02.03c

dev

dev

dev

commit with tag nightly-24.02.04

commit with tag nightly-24.02.04a

commit with tag nightly-24.02.04b

commit with tag ightly-24.02.04bc

commit with tag nightly-24.02.04bc

commit with tag a

commit with tag nightly-24.02.05

commit with tag nightly-24.01.30

commit with tag nightly-24.01.30a

commit with tag nightly-24.01.30b

commit with tag nightly-24.02.05a

dev

commit with tag nightly-24.02.05b

commit with tag nightly-24.02.06

commit with tag nightly-24.02.11

dev

dev

attemp no root user for netem

no root user for netem delay implemented in tools package

adding python actions for config backup restore

adding python actions - works UI and backend

adding python actions - works UI and backend

integrate diff to button1 and  enable dark mode

refactore - panels

refactor APIs - add cy-style-dark.json - touch up nav bar

refactor viewport-buttons viewport-drawer frontend

dev

dev

dev

dev

dev

commit with tag nightly-24.07.07

dev

dev

dev

dev

dev

get the actual clab impairment

get the actual clab impairment
there is a bug on  /usr/bin/containerlab tools netem show -n clab-nokia-ServiceProvider-R08-PE
+-----------+-------+--------+-------------+-------------+
| Interface | Delay | Jitter | Packet Loss | Rate (kbit) |
+-----------+-------+--------+-------------+-------------+
| lo        | N/A   | N/A    | N/A         | N/A         |
| eth0      | N/A   | N/A    | N/A         | N/A         |
| eth3      | N/A   | N/A    | N/A         | N/A         |
| eth3      | N/A   | N/A    | N/A         | N/A         |
| eth2      | 1ms   | 2ms    | 4.00%       |           3 |
| eth2      | N/A   | N/A    | N/A         | N/A         |
| eth4      | N/A   | N/A    | N/A         | N/A         |
| eth4      | N/A   | N/A    | N/A         | N/A         |
| eth5      | N/A   | N/A    | N/A         | N/A         |
| eth5      | N/A   | N/A    | N/A         | N/A         |
| br-mgmt   | N/A   | N/A    | N/A         | N/A         |
| int_cp    | N/A   | N/A    | N/A         | N/A         |
| tap0      | N/A   | N/A    | N/A         | N/A         |
| vcp-int   | N/A   | N/A    | N/A         | N/A         |
| vfpc1-int | N/A   | N/A    | N/A         | N/A         |
| tap2      | N/A   | N/A    | N/A         | N/A         |
| tap2      | N/A   | N/A    | N/A         | N/A         |
| tap3      | N/A   | N/A    | N/A         | N/A         |
| tap3      | N/A   | N/A    | N/A         | N/A         |
| tap4      | N/A   | N/A    | N/A         | N/A         |
| tap4      | N/A   | N/A    | N/A         | N/A         |
| tap5      | N/A   | N/A    | N/A         | N/A         |
| tap5      | N/A   | N/A    | N/A         | N/A         |
+-----------+-------+--------+-------------+-------------+

get the actual clab impairment
there is a bug on  /usr/bin/containerlab tools netem show -n clab-nokia-ServiceProvider-R08-PE
+-----------+-------+--------+-------------+-------------+
| Interface | Delay | Jitter | Packet Loss | Rate (kbit) |
+-----------+-------+--------+-------------+-------------+
| lo        | N/A   | N/A    | N/A         | N/A         |
| eth0      | N/A   | N/A    | N/A         | N/A         |
| eth3      | N/A   | N/A    | N/A         | N/A         |
| eth3      | N/A   | N/A    | N/A         | N/A         |
| eth2      | 1ms   | 2ms    | 4.00%       |           3 |
| eth2      | N/A   | N/A    | N/A         | N/A         |
| eth4      | N/A   | N/A    | N/A         | N/A         |
| eth4      | N/A   | N/A    | N/A         | N/A         |
| eth5      | N/A   | N/A    | N/A         | N/A         |
| eth5      | N/A   | N/A    | N/A         | N/A         |
| br-mgmt   | N/A   | N/A    | N/A         | N/A         |
| int_cp    | N/A   | N/A    | N/A         | N/A         |
| tap0      | N/A   | N/A    | N/A         | N/A         |
| vcp-int   | N/A   | N/A    | N/A         | N/A         |
| vfpc1-int | N/A   | N/A    | N/A         | N/A         |
| tap2      | N/A   | N/A    | N/A         | N/A         |
| tap2      | N/A   | N/A    | N/A         | N/A         |
| tap3      | N/A   | N/A    | N/A         | N/A         |
| tap3      | N/A   | N/A    | N/A         | N/A         |
| tap4      | N/A   | N/A    | N/A         | N/A         |
| tap4      | N/A   | N/A    | N/A         | N/A         |
| tap5      | N/A   | N/A    | N/A         | N/A         |
| tap5      | N/A   | N/A    | N/A         | N/A         |
+-----------+-------+--------+-------------+-------------+

commit with tag nightly-24.07.12

commit with tag nightly-24.07.07a

commit with tag nightly-24.07.13

update getGithubApi.sh to be able to fetch spesific version

commit with tag nightly-24.07.14

dev

dev

dev

dev

commit with tag nightly-24.07.14

commit with tag nightly-24.07.18

commit with tag nightly-24.07.19

commit with tag nightly-24.08.04

dev - backupRestore SRL JUNOS IOSXR

refactor clabHandler

refactor clabHandler - backupRestore

commit with tag nightly-24.08.06

add ssh-rsa in dockerfile

commit with tag nightly-24.08.13

add ssh-rsa in dockerfile

commit with tag nightly-24.09.04

commit with tag nightly-24.10.20

commit with tag nightly-24.10.20a

commit with tag nightly-24.10.20c

commit with tag nightly-24.10.20d

commit with tag nightly-24.10.20d

commit with tag nightly-24.10.20e

commit with tag nightly-24.10.20f

commit with tag nightly-24.10.20g

commit with tag nightly-24.10.21

commit with tag nightly-24.10.21a

commit with tag nightly-24.10.21b

commit with tag nightly-24.10.22

Track large file using Git LFS

commit with tag nightly-24.10.26a

commit with tag nightly-24.10.26b

commit with tag nightly-24.10.26c

devel

dev

commit with tag nightly-24.10.27

commit with tag nightly-24.10.27a

commit with tag nightly-24.10.30

Save changes before rebase

before rebase-squash
@asadarafat asadarafat closed this Oct 31, 2024
@asadarafat asadarafat deleted the development branch October 31, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants