Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add relative rule uid to report modules #167

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Add relative rule uid to report modules #167

merged 3 commits into from
Sep 10, 2024

Conversation

romanodanilo
Copy link
Contributor

@romanodanilo romanodanilo commented Sep 10, 2024 •
edited
Loading

Description

Addressing #160 and asam-ev/qc-opendrive#91, Add rule uid information to report modules

Text report example

 Checker:        performance_xodr
    Description:    Evaluates elements in the file to guarantee they are optimized.
    Status:         completed
    Summary:        
        Warning:    #3: Redudant line geometry declaration.
                       ruleUID: asam.net:xodr:1.7.0:performance.avoid_redundant_info
                       XPath: /OpenDRIVE/road[3]
                    Redundant line geometry declaration.
                       Location: x=228.68 y=96.2411 z=1

ReportGUI example
image

In TextReport also addressed #162

Example output

Total number of addressed rules:   1
Total number of violated rules:    1

Info violated rules:               1
	-> Info violation RuleUID: asam.net:xodr:1.7.0:road.geometry.param_poly3.length_match
Warning violated rules:            0
Error violated rules:              0

How was the PR tested?

  1. Unit-test with sample data. All unit tests passed.

@romanodanilo romanodanilo marked this pull request as ready for review September 10, 2024 13:50
@hoangtungdinh hoangtungdinh linked an issue Sep 10, 2024 that may be closed by this pull request
Text report adds rules from information issues to the number of violated rules #162
Closed
@romanodanilo
Cleaned output strings
361cadc 
Signed-off-by: romanodanilo <[email protected]>
hoangtungdinh
hoangtungdinh approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@hoangtungdinh hoangtungdinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @romanodanilo

@hoangtungdinh hoangtungdinh merged commit 0fcab42 into develop Sep 10, 2024
4 checks passed
@hoangtungdinh hoangtungdinh deleted the danilo/add_rule_uid_to_report_modules branch September 10, 2024 15:08
hoangtungdinh pushed a commit that referenced this pull request Sep 11, 2024
@romanodanilo @hoangtungdinh
Add relative rule uid to report modules (#167)
28e7b20 
Signed-off-by: romanodanilo <[email protected]>
@hoangtungdinh hoangtungdinh mentioned this pull request Sep 11, 2024
Merged
hoangtungdinh pushed a commit that referenced this pull request Oct 10, 2024
@romanodanilo @hoangtungdinh
Add relative rule uid to report modules (#167)
6c0505a 
Signed-off-by: romanodanilo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangtungdinh hoangtungdinh hoangtungdinh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text report adds rules from information issues to the number of violated rules
2 participants
@romanodanilo @hoangtungdinh