-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add convert list methods to the semantic HTML 5 converter #4321
base: feature/html-converter-next
Are you sure you want to change the base?
add convert list methods to the semantic HTML 5 converter #4321
Conversation
2c61693
to
f899d47
Compare
0d5ed60
to
cc33772
Compare
d41ea65
to
e1bc556
Compare
In summary: <ul class="list">
<li><span class="listitem">alice</span>
<ul>
<li>subpoint 1</li>
<li>subpoint 2</li>
</ul>
</li>
</ul> Should we also add the <ul class="list">
<li><span class="listtext">alice</span>
<ul>
<li><span class="listtext">subpoint 1</span></li>
<li><span class="listtext">subpoint 2</span></li>
</ul>
</li>
</ul> Regarding, description list should we use a <dl class="list qanda">
<dt>Question 1?</dt>
<dd><span class="desctext">Answer 1.</span></dd>
</dl> |
@ggrossetie Regarding /* For example if somebody wanted most fonts to be sans, but first level LIs to be serif, and subseqent nesting levels to go back to sans. Idk why anybody would want to change font family in particular, but I'm uncreative with my examples */
{
font-family: sans;
}
li {
font-family: serif;
}
li li {
font-family: sans;
} My personal preference would be to go with a system like this in CSS rather than adding extra spans and what not to facilitate a different system for writing CSS. But I understand that my opinions on CSS may differ from others, and that the spans don't prevent me from writing CSS in the shown manor. (They do cost extra characters on download, to the extent that actually matters with compression these days). |
Regarding |
How should we handle titles in lists. Currently we get
But that leaves us with |
From my experience styling HTML generated from AsciiDoc, I can say for certain that the Note that this tag is replacing a Keep in mind that it's not poor semantics to add additional tags, especially div and span. That thread traces all the way back to the CSS Zen Garden days. If there an insufficient amount of tags, it makes the designer have to resort to using a lot of hacks, which is what we're trying to get away from. What I'm not yet comfortable with is the name of the CSS class on it. I think that "listtext" is too specific when "text" would do. In CSS, you want to avoid redundant words in the hierarchy. If the class were just text, it could be targeted precisely using the |
It's the same argument. This is the principal text. There can be other tags inside |
I want to point out that in the spec, we're formalizing the name of the text of a list item, which precedes any attached blocks. That name is "principal text". That's why I still insist that the class be "principal" (as in span.principal) rather than "listtext" (or even "text" as I wrote above). Though since the formal term is "principal text" and the hierarchy suggests that it is principal based on its location, I would be willing to settle on "text". |
After reading some other threads in which the block title came up, I'm becoming convinced that it needs to be wrapped in a But the fact that we're using an inline tag, yet treating it as a block, I don't think is sufficient. I think it needs to be inside of a block tag like Again, keep in mind that we don't need to be austere with tags. What we're shooting for is something that looks readable and semantic with no stylesheet (or a deficient one like on GitHub) while at the same time being reasonable to style. There are a lot of concerns that the current HTML is awkward to target using CSS. If the structure we choose does not feel awkward, we will have achieved what we set out to achieve. There's no such thing as perfect HTML (even though many of probably yearn for such a thing, as I certainly do). |
I can give a go at working up something like this after work.
I think |
the |
I'd be open to exploring both ideas. |
I'm going to go for |
Okay, see work here ggrossetie#7 |
original work: @redbow-kimee