Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use grep -E instead of egrep #70

Merged
merged 1 commit into from
Jan 30, 2025
Merged

refactor: use grep -E instead of egrep #70

merged 1 commit into from
Jan 30, 2025

Conversation

egriff89
Copy link
Contributor

This removes the egrep is obsolescent warning when updating plugins with update or update-all.

Before:

asdf-plugin-manager.sh update-all
[INFO] Updating: venom https://github.com/aabouzaid/asdf-venom.git dea0c86 to HEAD
egrep: warning: egrep is obsolescent; using grep -E

After:

asdf-plugin-manager.sh update-all
[INFO] Updating: venom https://github.com/aabouzaid/asdf-venom.git dea0c86 to HEAD

@egriff89 egriff89 requested a review from a team as a code owner January 26, 2025 19:50
@aabouzaid aabouzaid changed the title chore: fix egrep is obsolescent warning refactor: use grep -E instead of egrep Jan 30, 2025
aabouzaid
aabouzaid approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@aabouzaid aabouzaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@egriff89 Thanks for the PR 🙌

@aabouzaid aabouzaid merged commit 00ba8ab into asdf-community:main Jan 30, 2025
6 checks passed
@egriff89 egriff89 deleted the egrep-fix branch January 30, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabouzaid aabouzaid aabouzaid approved these changes

Assignees

@egriff89 egriff89

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egriff89 @aabouzaid