Migrate build tooling to PNPM and NX #255
Open
+18,409
−20,322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @pavinduLakshan The migration to PNPM is complete. Could you please review it? |
| @@ -0,0 +1 @@ | |||
| shamefully-hoist=true | |||
There was a problem hiding this comment.
Could you explain the purpose of this?
There was a problem hiding this comment.
Comment on lines
+8
to
+9
| "start": "pnpm run server:local", | ||
| "prestart": "pnpm run build", |
There was a problem hiding this comment.
we may not need run. Please check
Suggested change
| "start": "pnpm run server:local", | |
| "prestart": "pnpm run build", | |
| "start": "pnpm server:local", | |
| "prestart": "pnpm build", |
There was a problem hiding this comment.
It works, But is it recommended?
| "install:server": "cd apps/server && yarn install", | ||
| "build:client": "cd apps/client && yarn run build", | ||
| "build:server": "cd apps/server && yarn run build" | ||
| "prebuild": "curr_dir=$(pwd) && pnpm run install:client && cd $curr_dir && pnpm run install:server", |
There was a problem hiding this comment.
We may not need run part. Please validate.
There was a problem hiding this comment.
It works, But is it recommended?
pavinduLakshan
requested review from
brionmario,
NipuniBhagya,
inthirakumaaran and
jeradrutnam
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate build tooling to PNPM and NX
Purpose
Goals