New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated non-static dataprovider -> static #158

Merged

ash-jc-allen merged 1 commit into ash-jc-allen:master from faissaloux:non-static-dataprovider

Jul 18, 2024

Contributor

faissaloux commented Jul 18, 2024 •

edited

Loading

Hellooo 👋

non-static data providers are deprecated since PHPUnit10 and it works fine with PHPUnit9.

In this PR I have made the one and only data provider in the test suite validDriversProvider static.


          deprecated non-static dataprovider -> static

293176c

ash-jc-allen merged commit c7d52e1 into ash-jc-allen:master

27 checks passed

Owner

ash-jc-allen commented Jul 18, 2024

Hey @faissaloux, that's awesome! Thanks for the contribution 😄

faissaloux deleted the non-static-dataprovider branch

July 18, 2024 13:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet