Removing a postgresql specific configuration from ash_sqlite.install
#103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachdaniel
requested changes
Nov 24, 2024
djgoku
force-pushed
the
chore-remove-setting-repo-port
branch
from
7e2a60f to
95af9be
Compare
zachdaniel
approved these changes
Dec 3, 2024
|
🚀 Thank you for your contribution! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not really sure how to test this except:
mix igniter.new igniter_ash_phoenix_sqlite_remove_p_port_configuring --install ash,ash_phoenix,ash_sqlite@github:djgoku/ash_sqlite@chore-remove-setting-repo-port --with phx.new --with-args="--database sqlite3"I have also attached the log below.removing-more-postgresql-log.txt
Just a thought, but if I am installing
ash_phoenixandash_sqlitecould we just add an implicit--with-args="--database sqlite3"since if you don't you'll have a few bits of postgresql to remove since phx.new defaults to installing for postgresql. Not really sure how to solve this, but was just thinking about it.