Skip to content

Commit

Permalink
Fix a failing unit test
Browse files Browse the repository at this point in the history
  • Loading branch information
ashishb-solo committed Nov 15, 2024
1 parent a6a35a3 commit 275117d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
changelog:
- type: NON_USER_FACING
description: >-
Fix failing unit test in `test/kubernetes/testutils/helper/util_test.go`
- type: NON_USER_FACING
issueLink: https://github.com/solo-io/solo-projects/issues/7223
resolvesIssue: false
description: >-
Remove hard-coded namespaces from the tracing tests. This issue is causing tests to pass in OSS gloo, but fail in solo-projects.
Remove hard-coded namespaces from the tracing tests. This issue is
causing tests to pass in OSS gloo, but fail in solo-projects.
4 changes: 2 additions & 2 deletions test/kubernetes/testutils/helper/util_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ func TestReturnsLatestPatchForMinor(t *testing.T) {
ctx := context.Background()
// this is fine because this is a public repo
client := githubutils.GetClientWithOrWithoutToken(ctx)
minor, err := getLatestReleasedPatchVersion(ctx, client, "gloo", 1, 8)
minor, err := getLatestReleasedPatchVersion(ctx, client, "gloo", 1, 9)
require.NoError(t, err)

assert.Equal(t, "v1.8.37", minor.String())
assert.Equal(t, "v1.9.30", minor.String())
}

0 comments on commit 275117d

Please sign in to comment.