feat: add scripts to generate sample types and workout names #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jon Carl <[email protected]>
Open
|
This is a great major improvement, thank you! However, I haven't tested the .sh scripts (yet). |
|
I just used the fix in the PR. If this fix wasn't here then I would have wasted a lot of days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As iOS versions release there are new workouts and sample types available in HealthKit. This PR adds two scripts to automatically generate code for sample types and workouts.
By generating sample types we will support all sample types instead of sample types manually added. While doing this I discovered some sample types which Apple does not allow you to import so those are excluded.
By generating workout types all the newest workout types are supported. I also discovered that workouts with compound names were not correctly supported in the current version of the project. Example: importing a
Cross Trainingworkout didn't work correctly as it's calledCrossTrainingin the xml. This is fixed using the generated code and I added a test case as well.I discovered that if you import a
HKCategoryTypeIdentifierAudioExposureEventwith the value of 0 HealthKit will error out. I added code so as to avoid that.