Shareand delete #42
Open
Shareand delete #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cimplesid
reviewed
Oct 15, 2020
| @@ -43,6 +44,10 @@ Future cropImage(String imagepath, Function(String) onCrop) async { | |||
| } | |||
| } | |||
|
|
|||
| void showToast(String msg) { | |||
| Fluttertoast.showToast(msg: msg, gravity: ToastGravity.BOTTOM); | |||
There was a problem hiding this comment.
Get.showSnackbar() use this remove fluttertoast
cimplesid
reviewed
Oct 15, 2020
| @@ -1,4 +1,5 @@ | |||
| import 'dart:io'; | |||
| import 'package:fluttertoast/fluttertoast.dart'; | |||
cimplesid
reviewed
Oct 15, 2020
| @@ -27,4 +28,7 @@ class ImageToPdfController extends GetxController { | |||
| } | |||
|
|
|||
| void removeImage(int index) => _images.removeAt(index); | |||
| void showToast(String msg) { | |||
| Fluttertoast.showToast(msg: msg, gravity: ToastGravity.BOTTOM); | |||
cimplesid
reviewed
Oct 15, 2020
| @@ -7,6 +7,7 @@ import 'package:EasyScan/Utils/constants.dart'; | |||
| import 'package:EasyScan/widgets/history_card.dart'; | |||
| import 'package:EasyScan/Utils/permission_checker.dart'; | |||
| import 'package:native_pdf_renderer/native_pdf_renderer.dart'; | |||
| import 'package:share/share.dart'; | |||
cimplesid
reviewed
Oct 15, 2020
| final file = dd.File(fileSystemEntitys[index].path); | ||
| file.delete(recursive: false); | ||
| } catch (e) { | ||
| //error will be here |
cimplesid
reviewed
Oct 15, 2020
| _savedPdfController.refreshFiles(); | ||
| _savedPdfController.deleteFile(i); | ||
| showToast("Pdf has been deleted"); | ||
| Get.to(HomeScreen()); |
cimplesid
reviewed
Oct 15, 2020
| onPressed: () { | ||
| _imageToPdfController.exportToPdf(); | ||
| showToast("Pdf has been created"); | ||
| Get.to(HomeScreen()); |
cimplesid
reviewed
Oct 15, 2020
| @@ -0,0 +1,26 @@ | |||
| import 'package:flutter/material.dart'; | |||
|
|
|||
| class ShareDelOption extends StatelessWidget { | |||
There was a problem hiding this comment.
better naming like customRow or customDialogOption
cimplesid
reviewed
Oct 15, 2020
| class ShareDelOption extends StatelessWidget { | ||
| final IconData iconData; | ||
| final String title; | ||
| final Color color; |
cimplesid
reviewed
Oct 15, 2020
| return Row( | ||
| mainAxisSize: MainAxisSize.min, | ||
| children: [ | ||
| Icon( |
There was a problem hiding this comment.
either user Icon as parameter or give default value to color
cimplesid
reviewed
Oct 15, 2020
| final IconData iconData; | ||
| final String title; | ||
| final Color color; | ||
| const ShareDelOption({Key key, this.iconData, this.title, this.color}) |
There was a problem hiding this comment.
make iconData & title required
cimplesid
reviewed
Oct 15, 2020
| @@ -42,6 +43,19 @@ class PdfController extends GetxController { | |||
| } | |||
| } | |||
|
|
|||
| void share({int index}) { | |||
There was a problem hiding this comment.
make index required parameter remove curly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functions added
share and delete pdf within an app
toast msg to alert user about pdf is created and deleted