Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use rules_workflows for CircleCI config generation #622

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: use rules_workflows for CircleCI config generation #622

wants to merge 1 commit into from
+33 −106

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Feb 6, 2024 •
edited
Loading

@gregmagolan gregmagolan marked this pull request as draft February 6, 2024 12:35
@gregmagolan gregmagolan marked this pull request as ready for review February 6, 2024 12:45
alexeagle
alexeagle reviewed Feb 7, 2024
View reviewed changes
WORKSPACE

fetch_workflows_deps()
fetch_workflows_tools(workflows_version = "5.9.2")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should rules_workflows be versioned with workflows, so you don't have to choose two separate versions when installing this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possibly... this is on the agenda for tech leads so lets discuss there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@mattem mattem Awaiting requested review from mattem

Assignees
No one assigned
Labels
None yet
Projects
Open Source
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregmagolan @alexeagle