Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add note about fetching tags during release #767

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Oct 30, 2024

So I don't forget next time...


Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

Copy link

aspect-workflows bot commented Oct 30, 2024

Test

All tests were cache hits

208 tests (100.0%) were fully cached saving 9m 31s.


Buildifier      Format

@jbedard
Copy link
Member Author

jbedard commented Oct 30, 2024

FWIW the issue prompting this was me tagging + pushing a release without first doing git fetch --tags first. So the generated locally was not up to date, but the tag generated by CI for the binaries (but not the release notes) was correct (see #766).

Why does CI generate the tag again? I'm not sure if that's worth investigating or fixing now, but fyi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant