Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cxxopt flags when linting C sources. #359

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

agoessling
Copy link
Contributor

Previously cxxopts were used even if the source was a C file. Now cxxopts and copts are passed correctly to clang-tidy depending on the file type.


Changes are visible to end-users: no

Test plan

  • Manual testing; please provide instructions so we can reproduce:

Include a C++ only flag in .bazelrc e.g. build --cxxopt="-std=c++17" and lint a C target.

Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@alexeagle alexeagle merged commit 5d056cb into aspect-build:main Aug 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants