Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: point to non-deprecated rustfmt #392

Merged
merged 3 commits into from
Sep 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion example/MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ bazel_dep(name = "rules_jvm_external", version = "4.5")
bazel_dep(name = "rules_go", version = "0.42.0", repo_name = "io_bazel_rules_go")
bazel_dep(name = "rules_proto", version = "6.0.0")
bazel_dep(name = "rules_python", version = "0.26.0")
bazel_dep(name = "rules_rust", version = "0.45.1")
bazel_dep(name = "rules_rust", version = "0.50.1")
bazel_dep(name = "buildifier_prebuilt", version = "6.3.3")
bazel_dep(name = "platforms", version = "0.0.8")
bazel_dep(name = "rules_kotlin", version = "1.9.0")
Expand Down
5 changes: 2 additions & 3 deletions example/WORKSPACE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -273,9 +273,8 @@ kt_register_toolchains()

http_archive(
name = "rules_rust",
integrity = "sha256-Eg0TqoZgX2BG0VEhB6qfWrxL5luctWwFhogWgtzYQ78=",
strip_prefix = "rules_rust-4a3ffcb1e89b3f20b12a37b55595682f4bc866b7",
urls = ["https://github.com/bazelbuild/rules_rust/archive/4a3ffcb1e89b3f20b12a37b55595682f4bc866b7.tar.gz"],
integrity = "sha256-MZscNcESBO9WsdlKVJ9rnTUygTt3jwLXCe9oyDcDbPE=",
urls = ["https://github.com/bazelbuild/rules_rust/releases/download/0.50.1/rules_rust-v0.50.1.tar.gz"],
)

load("@rules_rust//rust:repositories.bzl", "rules_rust_dependencies", "rust_register_toolchains")
Expand Down
6 changes: 5 additions & 1 deletion example/tools/format/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,11 @@ format_multirun(
markdown = ":prettier",
protocol_buffer = "//tools/lint:buf",
python = "@aspect_rules_lint//format:ruff",
rust = "@rules_rust//tools/rustfmt:upstream_rustfmt",
# Note, older rules_rust versions may need
# @rules_rust//tools/rustfmt:upstream_rustfmt
# which was later deprecated in
# https://github.com/bazelbuild/rules_rust/pull/2703
rust = "@rules_rust//tools/upstream_wrapper:rustfmt",
scala = ":scalafmt",
shell = "@aspect_rules_lint//format:shfmt",
sql = ":prettier",
Expand Down
Loading