Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example: Add example for pybind11 #375

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hofbi
Copy link
Contributor

@hofbi hofbi commented Jul 31, 2024

Add an example for pybind11 with rules_py which is a modified version of https://github.com/pybind/pybind11_bazel/tree/master/examples/basic.


Changes are visible to end-users: no

Test plan

  • New test cases added

@alexeagle
Copy link
Member

Thanks! but it doesn't appear this is being tested by our CI. We also don't have sub-modules in the other examples folders. Could you move the new dependency to the root MODULE.bazel (with dev_dependency=True) and verify this is getting tested?

@hofbi
Copy link
Contributor Author

hofbi commented Aug 3, 2024

Can do.

Isn't the UV example I am bumping in #374 a submodule?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants