Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add py_image_layer #402

Merged
merged 7 commits into from
Oct 4, 2024
Merged

feat: add py_image_layer #402

merged 7 commits into from
Oct 4, 2024

Conversation

thesayyn
Copy link
Member

@thesayyn thesayyn commented Oct 3, 2024

Replaces #349

Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: yes

Add py_image_layer macro for creating py container images.

Test plan

I will add a test in a follow-up.

MODULE.bazel Show resolved Hide resolved
Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

py/private/py_image_layer.bzl Outdated Show resolved Hide resolved
py/private/py_image_layer.bzl Outdated Show resolved Hide resolved
docs/BUILD.bazel Outdated Show resolved Hide resolved
@thesayyn thesayyn merged commit c155afa into main Oct 4, 2024
14 checks passed
@thesayyn thesayyn deleted the py_image_layer2 branch October 4, 2024 18:30
Comment on lines +137 to +138
groups = dict(**layer_groups)
group_names = groups.keys() + ["default"]
Copy link

@hartikainen hartikainen Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope I'm not adding any unintentional noise here, especially since I'm still very new to Bazel. I was browsing through these Bazel rules and noticed that there might be a bug here. I wonder if these two lines should be something like:

    groups = dict(default_layer_groups.items() + layer_groups.items())
    group_names = default_layer_groups.keys() + groups.keys()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants