-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add py_image_layer #402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
groups = dict(**layer_groups) | ||
group_names = groups.keys() + ["default"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope I'm not adding any unintentional noise here, especially since I'm still very new to Bazel. I was browsing through these Bazel rules and noticed that there might be a bug here. I wonder if these two lines should be something like:
groups = dict(default_layer_groups.items() + layer_groups.items())
group_names = default_layer_groups.keys() + groups.keys()
Replaces #349
Changes are visible to end-users: yes
Add
py_image_layer
macro for creating py container images.Test plan
I will add a test in a follow-up.