Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to .NET Standard #62

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

tomasherceg
Copy link

@tomasherceg tomasherceg commented Apr 24, 2024

Entity Framework 6.4 is supported with the new .NET, but many developers also use the ASP.NET Identity Entity Framework. Their DbContext inherits from IdentityDbContext, making the migration to the new .NET impossible.

I have ported the Microsoft.AspNet.Identity.Core and Microsoft.AspNet.Identity.EntityFramework to netstandard2.1;net45 - the same targets as EntityFramework package has.

I have also copied the Owin hosting project and added AspNetCore version that tries to replicate its functionality as closely as possible - only removes many helper extension methods that seem to be redundant to the API we have in ASP.NET Core.

I have also gone through all tests and made them working on both versions (except for the tests of IAuthenticationManager API which is not present in the new .NET at all).

I am not sure if this PR can ever get merged as it is an old security-related library which probably has to go through some security review. Also, maybe it is not a good idea to encourage people to potentially use the old version ASP.NET Identity in new projects. However, I found it useful in several modernization projects as it allowed me to keep using EF6 temporarily and not to migrate everything at the same time.

@CZEMacLeod
Copy link

This looks like it could be really useful - especially when combined with the SystemWeb-Adapters project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants