-
Notifications
You must be signed in to change notification settings - Fork 58
Build 1.1.0-preview4 version of dotnet-publish-iis #299
Conversation
@@ -0,0 +1,39 @@ | |||
{ | |||
"version": "1.1.0-preview4-final", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we plan on keeping it around in dev 1.1.0-*
should suffice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't intend to. When I merge back to dev, this source code won't be making the trip back into the dev branch
Is there more info on getting I just migrated a
Otherwise, this is no biggie of course ... I can simply go back to a handmade
|
@guardrex this PR was meant to produce a version of dotnet-publish-iis for .NET Core 1.1 and project.json. As I stated earlier, the tool is not meant to work in MSBuild.
You should make sure to reference the Microsoft.NET.Sdk.Web package. This should include targets to transform the web.config as publish-iis did. cref https://www.nuget.org/packages/Microsoft.NET.Sdk.Web/1.0.0-alpha-20161104-2-112 |
@guardrex Make sure you have reference to web sdk version >=20161104-2-112. Both dotnet publish & publish from VS should handle the transform. If this is not happening, can you share the csproj? |
Yes, I pulled that post publish section and was just copying a handmade
☝️ that was happening early in the evening ... I screwed around with installed tooling ... I may have pulled down The csproj is at: https://gist.github.com/GuardRex/58bb9e17a9b372c7bfcd3f79043365ab Just for the moment, while I get past this
at the moment. I'll setup the targets for |
This is already added as part of : https://github.com/aspnet/websdk/blob/dev/src/Web/Microsoft.NET.Sdk.Web.ProjectSystem.Targets/netstandard1.0/Microsoft.NET.Sdk.Web.ProjectSystem.targets
|
😄 Yes, it's back to publishing now. Yes, I can get a tooling-generated That's an internal GH repo, but I did remove those entries. I removed Resultant working A couple of notes on the
Thanks @vijayrkn and @natemcmaster. I'm good. 👍 I'm just on stand-by for the Razor precomp bits to proceed migrating larger projects. |
I don't have any new information. These issues haven't been touched for a while ... aspnet/Tooling#252 |
Thank you, @guardrex! Sadly this matches what I am seeing. I was hopeful when I discovered |
@nil4 what things were you looking to transform in the web.config file? |
Anything under I was able to fill this gap in earlier versions by porting the CLI tool for XDT transforms. With the change to MSBuild, the CLI tool no longer works. MSBuild historically had support for XDT transforms for years using the |
Great @nil4! I have been waiting for this for a while, what is the expected release date for this update? |
That's the question I also have for @davidfowl or @sayedihashimi |
While waiting for the official solution, I updated |
@nil4 Thank you for working on this in Christmas |
dotnet-publish-iis. Identical to 1.0.0-preview4 except with support for .NET Core 1.1 and FTS dependencies.
This is like a cli dandelion we've tried to kill it many times, but it keeps popping up again because reasons.
But for real, this should be the final final version of this tool as it has been deprecated in favor of MSBuild targets in Microsoft.NET.Sdk.Web.
cc @muratg