Fix lint errors found by ruff

asreview · Jun 9, 2023 · 2c73102 · 2c73102
1 parent 905800c
commit 2c73102
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/.gitignore b/.gitignore
@@ -111,3 +111,5 @@ dmypy.json
 .pyre/
 
 # End of https://www.gitignore.io/api/python
+
+asreviewcontrib/makita/_version.py
diff --git a/asreviewcontrib/makita/_version.py b/asreviewcontrib/makita/_version.py
diff --git a/asreviewcontrib/makita/entrypoint.py b/asreviewcontrib/makita/entrypoint.py
@@ -43,7 +43,7 @@ class MakitaEntryPoint(BaseEntryPoint):
     def __init__(self):
         from asreviewcontrib.makita.__init__ import __version__
 
-        super(MakitaEntryPoint, self).__init__()
+        super().__init__()
 
         self.version = __version__
 

diff --git a/asreviewcontrib/makita/template_multiple_models.py b/asreviewcontrib/makita/template_multiple_models.py
@@ -8,6 +8,9 @@
 from asreviewcontrib.makita.utils import FileHandler
 from asreviewcontrib.makita.utils import check_filename_dataset
 
+ALL_CLASSIFIERS = ["logistic", "nb", "rf", "svm"]
+ALL_FEATURE_EXTRACTORS = ["doc2vec", "sbert", "tfidf"]
+IMPOSSIBLE_MODELS = ["nb,doc2vec", "nb,sbert"]
 
 def render_jobs_multiple_models(
     datasets,
@@ -16,9 +19,9 @@ def render_jobs_multiple_models(
     scripts_folder="scripts",
     init_seed=535,
     model_seed=165,
-    all_classifiers=["logistic", "nb", "rf", "svm"],
-    all_feature_extractors=["doc2vec", "sbert", "tfidf"],
-    impossible_models=["nb,doc2vec", "nb,sbert"],
+    all_classifiers=ALL_CLASSIFIERS,
+    all_feature_extractors=ALL_FEATURE_EXTRACTORS,
+    impossible_models=IMPOSSIBLE_MODELS,
     fp_template=None,
     job_file='jobs.sh',
 ):
Original file line number	Diff line number	Diff line change
Expand Up		@@ -111,3 +111,5 @@ dmypy.json
		.pyre/

		# End of https://www.gitignore.io/api/python

		asreviewcontrib/makita/_version.py