Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename dataset and output folder in Prior template #67

Merged
merged 6 commits into from
Oct 24, 2024

Conversation

Rensvandeschoot
Copy link
Member

@Rensvandeschoot Rensvandeschoot commented Oct 6, 2024

This pull request makes the naming conventions for datasets and output folders more intuitive and consistent, specifically:

  • Renames the generated dataset with prior knowledge to dataset_custom_priors.
  • Renames the output folder for results from data with custom priors to sim_custom_priors.asreview.
  • Renames the output folder for results from data without priors to sim_minimal_priors.asreview.

These changes improve the legend labels to describe the datasets more accurately. Instead of using "with" and "without" (which may be ambiguous), the labels now clearly distinguish between "custom" and "minimal" priors, better reflecting the actual scenario.

Below is an updated plot with the new legend labels, using "custom" and "minimal" for clearer distinction (note that the colors are solved in #66):

plot_recall_sim
s

@Rensvandeschoot Rensvandeschoot marked this pull request as ready for review October 8, 2024 12:42
@jteijema jteijema merged commit c002482 into asreview:main Oct 24, 2024
4 checks passed
@Rensvandeschoot Rensvandeschoot deleted the rename_without_prior branch October 24, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants