Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data Brons_2024 #130

Open
wants to merge 4 commits into
base: development/v2
Choose a base branch
from

Conversation

renskebos
Copy link

No description provided.

@J535D165 J535D165 requested a review from EmilyWes January 28, 2025 13:40
@J535D165 J535D165 added enhancement New feature or request new-dataset Propose new dataset to be added to the collection labels Jan 28, 2025
Copy link
Contributor

@EmilyWes EmilyWes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Could you also add an entry in the datasets.toml file?
You can see other PR's or current datasets for what should be in there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not needed. Could you leave it out?

df= utils.drop_duplicates(df)

# Write output
utils.write_ids_files("Brons_2024", df)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End of file line is missing. Could you run "ruff format compose.py"? This will fix the end of file line as well as improve some other formatting.

@EmilyWes EmilyWes self-requested a review February 3, 2025 14:27
Copy link
Contributor

@EmilyWes EmilyWes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@J535D165 Ready to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new-dataset Propose new dataset to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants