-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data Brons_2024 #130
base: development/v2
Are you sure you want to change the base?
Add data Brons_2024 #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Could you also add an entry in the datasets.toml file?
You can see other PR's or current datasets for what should be in there.
datasets/Brons_2024/.DS_Store
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is not needed. Could you leave it out?
datasets/Brons_2024/compose.py
Outdated
df= utils.drop_duplicates(df) | ||
|
||
# Write output | ||
utils.write_ids_files("Brons_2024", df) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
End of file line is missing. Could you run "ruff format compose.py"? This will fix the end of file line as well as improve some other formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@J535D165 Ready to merge
No description provided.