Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link for your_dataset.py in README #6

Closed
wants to merge 1 commit into from
Closed

Fix broken link for your_dataset.py in README #6

wants to merge 1 commit into from

Conversation

VeenDuco
Copy link

@VeenDuco VeenDuco commented Jun 9, 2022

Changed the link that resulted in 404 error into the permalink.

Changed the link that resulted in 404 error into the permalink.
@@ -28,7 +28,7 @@ and replace `{USER_NAME}` and `{REPO_NAME}` by your own details.
## Usage

The new dataset is defined in
[`asreviewcontrib/dataset_name/your_dataset.py`](asreviewcontrib\dataset_name\your_dataset.py)
[`asreviewcontrib/dataset_name/your_dataset.py`](https://github.com/asreview/template-extension-new-dataset/blob/3fbbcc26c73cfd91aa7e47bd89bfca076ea1e981/asreviewcontrib/dataset_name/your_dataset.py)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to use a branch name instead of a commit hash.

@jteijema
Copy link
Member

jteijema commented Jun 17, 2022

Fixed in #8.

@jteijema jteijema closed this Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants