Update signature and skip :session blocks #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-block Since 0625651e (Update to Org 9.6-3-ga4d38e) ob-async has been broken on the emacs-29 branch. Fix this by expanding the function to include &rest other-args and future proofing against org-mode adding new arguments that ob-async doesn't need to see. Fixes: astahlman#92 Signed-off-by: Alex Bennée <[email protected]> --- v2 - use &rest for the new arg - use apply to call the original function v3 - use other-args
We shall shortly be adding a new skip condition. Before that lets re-factor the code into its own internal function. Signed-off-by: Alex Bennée <[email protected]>
More recent versions of org-mode have proper support of async session support so we shouldn't attempt to intercept those calls. Signed-off-by: Alex Bennée <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into issues with buffer references being passed when async evaluating python code (I suspect similar to what @vidbina was seeing in #88, #89). As python has "native" :async support in the latest org-mode I wanted to use that without dumping ob-async entirely. This series does a light refactor on the skipping code and will also skip :session tagged jobs.
It also includes the previous PR #93.