Enforce UTF-8 encoding for input bytes #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asticode
requested changes
Oct 8, 2024
srt_test.go
Outdated
| assert.Error(t, err) | ||
| } | ||
|
|
||
| func BenchmarkOpenSRT(b *testing.B) { |
There was a problem hiding this comment.
Could you remove this benchmark?
webvtt_test.go
Outdated
| @@ -227,3 +233,11 @@ func TestWebVTTTags(t *testing.T) { | |||
| Text with a <00:06:30.000>timestamp in the middle | |||
| `, b.String()) | |||
| } | |||
|
|
|||
| func BenchmarkOpenWebVTT(b *testing.B) { | |||
There was a problem hiding this comment.
Could you remove this benchmark?
Cool, removed. Thanks @asticode! |
|
Thanks for the PR! ❤️ Let me know whether you need a tag 👍 |
|
@asticode A tag would be great thanks! |
|
FYI I've created a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #114, it would be better if we tried not to read bytes in other encoding if possible, as the parsers will become confused since they are generally using strings from a go source file (UTF-8) to compare against the input bytes which may or may not be UTF-8.