feat: Issues-116 support options for WriteToTTML #117
Conversation
min0625
force-pushed
the
feat/issues-116-support-options-for-writetottml
branch
from
84b59d7
to
db64f6e
Compare
ttml_test.go
Outdated
|
|
||
| func TestTTMLWithOptionsNoIndent(t *testing.T) { | ||
| // Open | ||
| s, err := astisub.OpenFile("./testdata/example-in-no-indent.ttml") |
There was a problem hiding this comment.
Why add this new in file? Can't you use ./testdata/example-in.ttml directly?
There was a problem hiding this comment.
Why add this new in file?
I want to decouple the test file in the two test cases, so I add a new file for the test case.
Can't you use ./testdata/example-in.ttml directly?
Yes, I can use directly, If you think it is better.
There was a problem hiding this comment.
I understand but I'd rather use ./testdata/example-in.ttml here 👍
There was a problem hiding this comment.
OK, will fix it soon.
ttml_test.go
Outdated
| @@ -68,3 +68,20 @@ func TestTTMLBreakLines(t *testing.T) { | |||
|
|
|||
| assert.Equal(t, strings.TrimSpace(string(c)), strings.TrimSpace(w.String())) | |||
| } | |||
|
|
|||
| func TestTTMLWithOptionsNoIndent(t *testing.T) { | |||
There was a problem hiding this comment.
Can you rename this test to TestWriteToTTMLWithIndentOption?
There was a problem hiding this comment.
OK, will rename it later.
|
Thanks for the PR! ❤️ Let me know whether you need a tag 👍 |
|
Yes, I need a tag. Thank you! |
|
I've created the |
Issue: #116