Narrow Text edits #374
Merged
Narrow Text edits #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
force-pushed
the
narrow-edits
branch
5 times, most recently
from
29d0ef8 to
12b9548
Compare
charliermarsh
approved these changes
Feb 1, 2024
MichaReiser
force-pushed
the
narrow-edits
branch
from
12b9548 to
0f16d4f
Compare
dhruvmanila
approved these changes
Feb 2, 2024
MichaReiser
force-pushed
the
narrow-edits
branch
from
0f16d4f to
3b59a36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Try to narrow text edits to changed lines only. The implemented algorithm is very basic. It only trims the common suffix and postfix (line based) but doesn't do any diffing beyond that.
The idea is to have a fast (with predictable performance) algorithm that at least avoids transmitting the entire formatted file when doing range formatting.
Test Plan
I played with range formatting, code fixes, and normal formatting in the VS code extension to verify that it doesn't truncate text.