Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConfigurationPreference::FilesystemOnly #16258

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Resolves #16209.

When configurationPreference is set to filesystemOnly, Ruff ignores all editor-level configurations. This is the same as editorOnly, but inverted.

Test Plan

None.

@InSyncWithFoo
Copy link
Contributor Author

InSyncWithFoo commented Feb 19, 2025

This seems surprisingly easy. I take it that the versioning problem mentioned in #16209 is to be handled within the extension?

Copy link
Contributor

github-actions bot commented Feb 19, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser
Copy link
Member

MichaReiser commented Feb 19, 2025

Could you please add a test plan (video?) demonstrating that this works as expected.

I'm also not sure if this is something we have a decision on or if it's just a feature request. @dhruvmanila ?

@MichaReiser MichaReiser added the server Related to the LSP server label Feb 19, 2025
@dhruvmanila
Copy link
Member

I'm also not sure if this is something we have a decision on or if it's just a feature request. @dhruvmanila ?

I think it makes sense to add it.

This seems surprisingly easy. I take it that the versioning problem mentioned in #16209 is to be handled within the extension?

It also requires updating the VS Code extension to allow the value in the editor settings. By versioning problem, I mainly meant that it might be good to check the Ruff version in the extension to see if this value is supported or not and handle it on the extension side otherwise the server will raise a deserialization error.

@MichaReiser
Copy link
Member

I'll reply on the issue. Let's keep this in draft and re-publish once we're aligned on the behavior.

@MichaReiser MichaReiser marked this pull request as draft February 20, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server Related to the LSP server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new configurationPreference value filesystemOnly
3 participants