fix: unexpected abort when symlink to non-regular file #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fourdim
force-pushed
the
init-symlink
branch
from
519a3bd to
dfd60a8
Compare
| #[cfg(unix)] | ||
| { | ||
| if target.is_absolute() && target.starts_with(from) { | ||
| symlink_file(target.strip_prefix(from).unwrap(), &destination) |
There was a problem hiding this comment.
Why is the strip_prefix here necessary?
There was a problem hiding this comment.
For example:
If we have a folder symlink:
/project/folder -> /project/folder2
And we want to copy it to /tmp,
It is apparently we don't want this:
/tmp/folder -> /project/folder2
This one is more reasonable, isn't it?
/tmp/folder -> ./folder2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::fs::copywill return an error whenhttps://doc.rust-lang.org/std/fs/fn.copy.html
Error screenshot:
Windows part is not tested.