Respect markers on constraints #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let constraints_txt = temp_dir.child("constraints.txt"); | ||
| constraints_txt.touch()?; | ||
| constraints_txt.write_str("aiohttp==3.8.5;python_version<'3.12'")?; | ||
| constraints_txt.write_str("aiohttp==3.9.0b0;python_version>='3.12'")?; |
There was a problem hiding this comment.
Can we add a test case that succeeds, e.g., add a dependency for python_version <= 3.7 and ensure it's not respected?
There was a problem hiding this comment.
Yeah I can. I don't know about this test case it's not really doing what I want.
There was a problem hiding this comment.
I used a simpler dependency tree for this test, much better now.
zanieb
force-pushed
the
zanie/python-constraint-marker
branch
from
453a937 to
29d5fbc
Compare
zanieb
force-pushed
the
zanie/python-constraint-marker
branch
from
29d5fbc to
b89a9aa
Compare
charliermarsh
approved these changes
Nov 1, 2023
zanieb
force-pushed
the
zanie/python-constraint-marker
branch
from
b89a9aa to
f31ae70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #252