This repository has been archived by the owner on Jul 3, 2024. It is now read-only.
173 - No project/file differenciation #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
0xmemorygrinder
force-pushed
the
feature/173-no-project-file-differenciation-staging
branch
from
b3f7051 to
c0fe526
Compare
0xmemorygrinder
force-pushed
the
feature/173-no-project-file-differenciation-staging
branch
from
da99a14 to
8224345
Compare
0xSwapFeeder
force-pushed
the
feature/173-no-project-file-differenciation-staging
branch
2 times, most recently
from
a19fccd to
bbef0ce
Compare
ByFishh
approved these changes
Nov 2, 2023
0xmemorygrinder
suggested changes
Nov 2, 2023
0xmemorygrinder
assigned 0xSwapFeeder and unassigned EnergyCube, 0xmemorygrinder and ByFishh
Tell me if the versioning feels right |
0xmemorygrinder
suggested changes
Nov 2, 2023
| @@ -11,5 +11,5 @@ crate-type = ["cdylib", "rlib"] | |||
|
|
|||
| [dependencies] | |||
| osmium-libs-lsp-handler = { path = "../../../../../libs/lsp-handler", version = "0.0.1" } | |||
| solidhunter-lib = { path = "../linter-lib", version = "0.0.2" } | |||
| solidhunter-lib = { path = "../linter-lib", version = "0.0.3" } | |||
There was a problem hiding this comment.
Should be incremented as minor since it is in pre release and this is a breaking change
There was a problem hiding this comment.
ok, but there is no breaking change in the linter-lib tho, only added a pub function, the rest is only code cleaning and simplification doesn't change the usage.
Should I still mark it as a minor update ?
There was a problem hiding this comment.
Ok for the lib, the cli should have the minor increase though (-> 0.1.0)
There was a problem hiding this comment.
that's already the case then 👍
| @@ -2,7 +2,7 @@ | |||
| name = "solidhunter-lib" | |||
| description = "Solidhunter/Osmium solidity linter library" | |||
| repository = "https://github.com/astrodevs-labs/osmium" | |||
| version = "0.0.2" | |||
| version = "0.0.3" | |||
There was a problem hiding this comment.
Should be incremented as minor since it is in pre release and this is a breaking change
|
Please fix conflicts |
0xSwapFeeder
force-pushed
the
feature/173-no-project-file-differenciation-staging
branch
from
2cb6d82 to
4df7fbc
Compare
0xmemorygrinder
approved these changes
Nov 2, 2023
0xmemorygrinder
deleted the
feature/173-no-project-file-differenciation-staging
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #173