185 - Ignore linting file #195

github-actions · 2023-10-25T19:13:30Z

Solves #185

0xmemorygrinder

Please see comments and don't forget to increment crates versions

toolchains/solidity/core/crates/linter-lib/src/ignore.rs

toolchains/solidity/core/crates/linter-cli/src/main.rs

toolchains/solidity/core/crates/linter-lib/src/linter.rs

…ursivly

0xmemorygrinder

You should fix the failed CI checks and increment the version of linter-server crate

0xSwapFeeder

lgtm

0xmemorygrinder force-pushed the feature/185-ignore-linting-file-staging branch from 131d92d to de54591 Compare November 1, 2023 20:33

ByFishh force-pushed the feature/185-ignore-linting-file-staging branch from 2605481 to 7f6ac62 Compare November 3, 2023 10:10

EnzoBonato requested review from 0xmemorygrinder and 0xSwapFeeder November 3, 2023 14:24

EnzoBonato marked this pull request as ready for review November 3, 2023 14:27

0xmemorygrinder suggested changes Nov 3, 2023

View reviewed changes

toolchains/solidity/core/crates/linter-lib/src/ignore.rs Outdated Show resolved Hide resolved

toolchains/solidity/core/crates/linter-cli/src/main.rs Outdated Show resolved Hide resolved

toolchains/solidity/core/crates/linter-lib/src/linter.rs Outdated Show resolved Hide resolved

0xmemorygrinder assigned ByFishh and EnzoBonato Nov 3, 2023

Astrodevs CI and others added 7 commits November 6, 2023 13:35

chore: create branch feature/185-ignore-linting-file-staging

f6d6dc3

feat(solidity/linter): initialize function for solidhunter ignore

c9eab23

feat(solidity/linter): Adding new argument in main cli

f459475

feat(solidity/linter): load solidhunter ignore by default and tests

697ac13

feat(solidity/cli): initialize ignore file if set

826c32e

feat(solidity/linter): remove useless condition

72237b5

feat(solidity/linter): format

0d05c09

0xmemorygrinder force-pushed the feature/185-ignore-linting-file-staging branch from 1215509 to 0d05c09 Compare November 6, 2023 18:36

0xmemorygrinder and others added 6 commits November 6, 2023 20:23

feat(solidity/linter-cli): made exclude argument a list of files

c4d8e7a

feat(solidity/linter): made linter takes multiple paths to lint

d18f8a9

feat(solidity/linter): ignore files from every .solidhunterignore rec…

12e52be

…ursivly

feat(solidity/linter): starting SolidhunterIgnore test

f5c771f

feat(solidity/linter): test for solidhunterignore

bf11d09

feat(solidity/linter): version

a6cb9a0

ByFishh requested a review from 0xmemorygrinder November 9, 2023 15:11

0xmemorygrinder suggested changes Nov 9, 2023

View reviewed changes

ByFishh added 2 commits November 10, 2023 17:38

feat(solidity/linter): fix linting and format

c256273

feat(solidity/linter): change linter-server crate version

e701300

ByFishh requested a review from 0xmemorygrinder November 10, 2023 20:36

0xmemorygrinder approved these changes Nov 10, 2023

View reviewed changes

0xSwapFeeder approved these changes Nov 14, 2023

View reviewed changes

0xmemorygrinder merged commit 57660cb into dev Nov 14, 2023

0xmemorygrinder deleted the feature/185-ignore-linting-file-staging branch December 1, 2023 17:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

185 - Ignore linting file #195

185 - Ignore linting file #195

github-actions bot commented Oct 25, 2023

0xmemorygrinder left a comment

0xmemorygrinder left a comment

0xSwapFeeder left a comment

185 - Ignore linting file #195

185 - Ignore linting file #195

Conversation

github-actions bot commented Oct 25, 2023

0xmemorygrinder left a comment

Choose a reason for hiding this comment

0xmemorygrinder left a comment

Choose a reason for hiding this comment

0xSwapFeeder left a comment

Choose a reason for hiding this comment